From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19512 invoked by alias); 24 Apr 2006 10:11:27 -0000 Received: (qmail 19495 invoked by uid 22791); 24 Apr 2006 10:11:27 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 24 Apr 2006 10:11:25 +0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id k3OABKnY000638; Mon, 24 Apr 2006 12:11:20 +0200 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id k3OABK6j000637; Mon, 24 Apr 2006 12:11:20 +0200 Date: Mon, 24 Apr 2006 10:11:00 -0000 From: Jakub Jelinek To: Ulrich Drepper , Roland McGrath Cc: Glibc hackers Subject: [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c Message-ID: <20060424101119.GD4651@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00011.txt.bz2 Hi! So far I think none of the 32-bit big endian arches support this syscall (and ppc32 will likely need its own implementation of this, as it requires long long args to be at padded to even arguments), but certainly it doesn't hurt to follow what linux/posix_fadvise{,64}.c is already doing. 2006-04-24 Jakub Jelinek * sysdeps/unix/sysv/linux/sync_file_range.c (sync_file_range): Use __LONG_LONG_PAIR macro. --- libc/sysdeps/unix/sysv/linux/sync_file_range.c 14 Apr 2006 08:07:56 -0000 1.1 +++ libc/sysdeps/unix/sysv/linux/sync_file_range.c 24 Apr 2006 10:01:53 -0000 @@ -29,9 +29,10 @@ int sync_file_range (int fd, __off64_t from, __off64_t to, int flags) { - return INLINE_SYSCALL (sync_file_range, 6, fd, (off_t) (from >> 32), - (off_t) (from & 0xffffffff), (off_t) (to >> 32), - (off_t) (to & 0xffffffff), flags); + return INLINE_SYSCALL (sync_file_range, 6, fd, + __LONG_LONG_PAIR ((long) (from >> 32), (long) from), + __LONG_LONG_PAIR ((long) (to >> 32), (long) to), + flags); } #else int Jakub