From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix initgrcache.c
Date: Tue, 05 Sep 2006 10:28:00 -0000 [thread overview]
Message-ID: <20060905102751.GS4556@sunsite.mff.cuni.cz> (raw)
Hi!
If malloc fails, it will goto out and use there an uninitialized
any_success variable.
2006-09-05 Jakub Jelinek <jakub@redhat.com>
* nscd/initgrcache.c (addinitgroupsX): Move any_success
decl before first goto out.
--- libc/nscd/initgrcache.c.jj 2006-08-03 19:36:25.000000000 +0200
+++ libc/nscd/initgrcache.c 2006-09-05 12:20:29.000000000 +0200
@@ -107,6 +107,7 @@ addinitgroupsX (struct database_dyn *db,
long int start = 0;
bool all_tryagain = true;
+ bool any_success = false;
/* This is temporary memory, we need not (ad must not) call
mempool_alloc. */
@@ -117,7 +118,6 @@ addinitgroupsX (struct database_dyn *db,
goto out;
/* Nothing added yet. */
- bool any_success = false;
while (! no_more)
{
long int prev_start = start;
Jakub
next reply other threads:[~2006-09-05 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 10:28 Jakub Jelinek [this message]
2006-09-05 14:36 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060905102751.GS4556@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).