From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1045 invoked by alias); 6 Sep 2006 16:37:34 -0000 Received: (qmail 1029 invoked by uid 22791); 6 Sep 2006 16:37:33 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Sep 2006 16:37:17 +0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id k86Gb4Di029878; Wed, 6 Sep 2006 18:37:04 +0200 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id k86Gb3jq029877; Wed, 6 Sep 2006 18:37:03 +0200 Date: Wed, 06 Sep 2006 16:37:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Fix uninitialized var in gai_suspend Message-ID: <20060906163703.GU4556@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00006.txt.bz2 Hi! GAI_MISC_WAIT macro only sets result on error, so without this patch we return an uninitialized value. 2006-09-06 Jakub Jelinek * resolv/gai_suspend.c (gai_suspend): Make sure result is initialized. --- libc/resolv/gai_suspend.c.jj 2006-08-03 10:03:46.000000000 +0200 +++ libc/resolv/gai_suspend.c 2006-09-06 17:30:22.000000000 +0200 @@ -83,6 +83,7 @@ gai_suspend (const struct gaicb *const l pthread_setcancelstate (PTHREAD_CANCEL_DISABLE, &oldstate); #ifdef DONT_NEED_GAI_MISC_COND + result = 0; GAI_MISC_WAIT (result, cntr, timeout, 1); #else if (timeout == NULL) Jakub