From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix uninitialized vars in ld-collate.c
Date: Wed, 06 Sep 2006 16:41:00 -0000 [thread overview]
Message-ID: <20060906164051.GV4556@sunsite.mff.cuni.cz> (raw)
Hi!
col_sym_free label is in a different block and frees what local variables
in that block point to, guess that's a typo.
seqp was declared in 2 different blocks and one was in some cases using
goto to jump to the other block.
2006-09-06 Jakub Jelinek <jakub@redhat.com>
* locale/programs/ld-collate.c (collate_read): Goto sym_equiv_free rather than
col_sym_free. Move seqp declaration earlier.
--- libc/locale/programs/ld-collate.c.jj 2006-08-30 17:20:41.000000000 +0200
+++ libc/locale/programs/ld-collate.c 2006-09-06 18:33:31.000000000 +0200
@@ -3068,7 +3068,7 @@ collate_read (struct linereader *ldfile,
lr_error (ldfile, _("\
%s: unknown symbol `%s' in equivalent definition"),
"LC_COLLATE", symname);
- goto col_sym_free;
+ goto sym_equiv_free;
}
if (insert_entry (&collate->sym_table,
@@ -3533,13 +3533,13 @@ error while adding equivalent collating
break;
}
+ struct element_t *seqp;
if (state == 0)
{
/* We are outside an `order_start' region. This means
we must only accept definitions of values for
collation symbols since these are purely abstract
values and don't need directions associated. */
- struct element_t *seqp;
void *ptr;
if (find_entry (&collate->seq_table, symstr, symlen, &ptr) == 0)
@@ -3586,7 +3586,6 @@ error while adding equivalent collating
{
/* It is possible that we already have this collation sequence.
In this case we move the entry. */
- struct element_t *seqp = NULL;
void *sym;
void *ptr;
Jakub
next reply other threads:[~2006-09-06 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 16:41 Jakub Jelinek [this message]
2006-09-06 16:52 ` Ulrich Drepper
2006-09-06 16:53 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060906164051.GV4556@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).