From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-cond22.c
Date: Mon, 11 Sep 2006 07:32:00 -0000 [thread overview]
Message-ID: <20060911073207.GC4556@sunsite.mff.cuni.cz> (raw)
Hi!
tst-cond22.c occassionally fails with
first thread not canceled
cond = { 0, 2, 1, 1, 1, 0x804b140, 0, 0 }
cond = { 0, 4, 2, 2, 2, 0x804b140, 0, 0 }
The problem is that it relies on tf thread not being woken up (with
pthread_signal) before pthread_cancel is run. If tf is woken before
pthread_cancel is called in the initial thread, then the thread just runs
through until return NULL; and exits.
Alternatively, we could if (res == NULL) just try again a few times and only
give up (with no error) if the "first thread" has not been successfully
cancelled for say 16 or 32 times.
2006-09-11 Jakub Jelinek <jakub@redhat.com>
* tst-cond22.c (do_test): Don't insist the first thread has to be
cancelled.
--- libc/nptl/tst-cond22.c 2006-09-11 08:56:52.000000000 +0200
+++ libc/nptl/tst-cond22.c 2006-09-11 09:22:03.000000000 +0200
@@ -94,9 +94,9 @@ do_test (void)
puts ("1st join failed");
return 1;
}
- if (res != PTHREAD_CANCELED)
+ if (res != PTHREAD_CANCELED && res != NULL)
{
- puts ("first thread not canceled");
+ puts ("first thread not canceled nor exited successfully");
status = 1;
}
Jakub
reply other threads:[~2006-09-11 7:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060911073207.GC4556@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).