From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8699 invoked by alias); 15 Sep 2006 22:52:01 -0000 Received: (qmail 8680 invoked by uid 22791); 15 Sep 2006 22:52:00 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Sep 2006 22:51:55 +0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id k8FMpnRg030352; Sat, 16 Sep 2006 00:51:49 +0200 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id k8FMpjL3030343; Sat, 16 Sep 2006 00:51:45 +0200 Date: Fri, 15 Sep 2006 22:52:00 -0000 From: Jakub Jelinek To: Ulrich Drepper , Steven Munroe Cc: Glibc hackers Subject: [PATCH] Fix ppc* libSegFault.so register dump Message-ID: <20060915225144.GJ4556@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00028.txt.bz2 Hi! For ppc32 this just removes '\0' character that has been printed after the register dump and before the backtrace. For ppc64 libSegFault.so printed complete garbage. 2006-09-16 Jakub Jelinek * sysdeps/powerpc/powerpc32/register-dump.h (register_dump): Don't write '\0' to the fd. * sysdeps/mach/hurd/powerpc/register-dump.h (register_dump): Likewise. * sysdeps/powerpc/powerpc64/register-dump.h (register_dump): Likewise. Change regs to unsigned long pointer from unsigned int, fix fscr offset. --- libc/sysdeps/powerpc/powerpc64/register-dump.h.jj 2002-09-18 01:50:02.000000000 +0200 +++ libc/sysdeps/powerpc/powerpc64/register-dump.h 2006-09-16 00:43:48.000000000 +0200 @@ -1,5 +1,5 @@ /* Dump registers. - Copyright (C) 1998, 2002 Free Software Foundation, Inc. + Copyright (C) 1998, 2002, 2006 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -34,7 +34,7 @@ gr16-19: 000000000000010% 00000000000001 gr20-23: 000000000000014% 000000000000015% 000000000000016% 000000000000017%\n\ gr24-27: 000000000000018% 000000000000019% 00000000000001a% 00000000000001b%\n\ gr28-31: 00000000000001c% 00000000000001d% 00000000000001e% 00000000000001f%\n\ -fscr=0000071%\n\ +fscr=000000000000050%\n\ fp0-3: 000000000000030% 000000000000031% 000000000000032% 000000000000033%\n\ fp4-7: 000000000000034% 000000000000035% 000000000000036% 000000000000037%\n\ fp8-11: 000000000000038% 000000000000038% 00000000000003a% 00000000000003b%\n\ @@ -104,7 +104,7 @@ register_dump (int fd, struct sigcontext char buffer[sizeof(dumpform)]; char *bufferpos; unsigned regno; - unsigned *regs = (unsigned *)(ctx->regs); + unsigned long *regs = (unsigned long *)(ctx->regs); memcpy(buffer, dumpform, sizeof(dumpform)); @@ -117,7 +117,7 @@ register_dump (int fd, struct sigcontext } /* Write the output. */ - write (fd, buffer, sizeof(buffer)); + write (fd, buffer, sizeof(buffer) - 1); } --- libc/sysdeps/powerpc/powerpc32/register-dump.h.jj 2002-09-05 10:25:50.000000000 +0200 +++ libc/sysdeps/powerpc/powerpc32/register-dump.h 2006-09-16 00:44:07.000000000 +0200 @@ -1,5 +1,5 @@ /* Dump registers. - Copyright (C) 1998 Free Software Foundation, Inc. + Copyright (C) 1998, 2006 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -113,7 +113,7 @@ register_dump (int fd, struct sigcontext } /* Write the output. */ - write (fd, buffer, sizeof(buffer)); + write (fd, buffer, sizeof(buffer) - 1); } --- libc/sysdeps/mach/hurd/powerpc/register-dump.h.jj 2001-11-10 01:37:47.000000000 +0100 +++ libc/sysdeps/mach/hurd/powerpc/register-dump.h 2006-09-16 00:44:35.000000000 +0200 @@ -1,5 +1,5 @@ /* Dump registers. PowerPC/Hurd version. - Copyright (C) 1998, 2001 Free Software Foundation, Inc. + Copyright (C) 1998, 2001, 2006 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -113,7 +113,7 @@ register_dump (int fd, struct sigcontext } /* Write the output. */ - write (fd, buffer, sizeof(buffer)); + write (fd, buffer, sizeof(buffer) - 1); } #define REGISTER_DUMP \ Jakub