From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix __rtld_mrlock_{lock,change}
Date: Fri, 27 Oct 2006 08:32:00 -0000 [thread overview]
Message-ID: <20061027083211.GP5868@sunsite.mff.cuni.cz> (raw)
Hi!
__rtld_mrlock_{lock,change} can get into an endless loop. If lock is
changed between oldval = lock and the atomic compare and swap, the loop
will cycle until something changes lock back to the oldvalue (which doesn't
have to happen ever). When CAS is unsuccessful, we need to reread oldval,
either from lock directly or better yet from what CAS returned.
2006-10-27 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/rtld-lowlevel.h (__rtld_mrlock_lock,
__rtld_mrlock_change): Update oldval if atomic compare and exchange
failed.
--- libc/nptl/sysdeps/unix/sysv/linux/rtld-lowlevel.h.jj 2006-10-19 17:26:40.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/rtld-lowlevel.h 2006-10-25 21:36:37.000000000 +0200
@@ -67,6 +67,7 @@ typedef int __rtld_mrlock_t;
oldval); \
if (__builtin_expect (ret == oldval, 1)) \
goto out; \
+ oldval = ret; \
} \
atomic_delay (); \
} \
@@ -112,6 +113,7 @@ typedef int __rtld_mrlock_t;
oldval); \
if (__builtin_expect (ret == oldval, 1)) \
goto out; \
+ oldval = ret; \
} \
atomic_delay (); \
} \
Jakub
reply other threads:[~2006-10-27 8:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027083211.GP5868@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).