From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9103-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 30532 invoked by alias); 30 Oct 2006 00:26:54 -0000
Received: (qmail 30516 invoked by uid 22791); 30 Oct 2006 00:26:54 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Oct 2006 00:26:51 +0000
Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id k9U0QkDO003235;
	Mon, 30 Oct 2006 01:26:46 +0100
Received: (from jj@localhost)
	by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id k9U0QkTf003233;
	Mon, 30 Oct 2006 01:26:46 +0100
Date: Mon, 30 Oct 2006 00:26:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix pthread_spin_unlock on ia64
Message-ID: <20061030002645.GT5868@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2006-10/txt/msg00022.txt.bz2

Hi!

__sync_lock_release_si was an implementation detail of the old
<ia64intrin.h>'s __sync_lock_release macro.  GCC 4.1.x+ supports
only __sync_lock_release.
Now the question is why this hasn't been seen before, I think perhaps
nptl/sysdeps/pthread could be searched before nptl/sysdeps/ia64.

2006-10-30  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ia64/pthread_spin_unlock.c (pthread_spin_unlock): Use
	__sync_lock_release instead of __sync_lock_release_si.

--- libc/nptl/sysdeps/ia64/pthread_spin_unlock.c	2003-03-18 04:42:45.000000000 +0100
+++ libc/nptl/sysdeps/ia64/pthread_spin_unlock.c	2006-10-30 00:31:16.000000000 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003 Free Software Foundation, Inc.
+/* Copyright (C) 2003, 2006 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
 
@@ -23,6 +23,6 @@
 int
 pthread_spin_unlock (pthread_spinlock_t *lock)
 {
-  __sync_lock_release_si ((int *) lock);
+  __sync_lock_release ((int *) lock);
   return 0;
 }

	Jakub