From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix i386 sysconf at -O3
Date: Thu, 09 Nov 2006 23:29:00 -0000 [thread overview]
Message-ID: <20061109232947.GM5868@sunsite.mff.cuni.cz> (raw)
Hi!
At least with GCC 4.1.x and -O3 the register pressure on i?86 is too
high with all the inline asm for cpuid.
The following patch cures it and is IMHO desirable anyway, intel_check_word
is quite big and it is wasteful to replicate it 3 times.
2006-11-10 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/i386/sysconf.c (intel_check_word): Add
noinline attribute.
--- libc/sysdeps/unix/sysv/linux/i386/sysconf.c 2006-11-09 23:07:15.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/i386/sysconf.c 2006-11-09 23:07:15.000000000 +0100
@@ -139,7 +139,7 @@ intel_02_known_compare (const void *p1,
}
-static long int
+static long int __attribute__ ((noinline))
intel_check_word (int name, unsigned int value, bool *has_level_2,
bool *no_level_2_or_3)
{
Jakub
reply other threads:[~2006-11-09 23:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109232947.GM5868@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).