From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23643 invoked by alias); 21 Nov 2006 12:18:32 -0000 Received: (qmail 23626 invoked by uid 22791); 21 Nov 2006 12:18:31 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Nov 2006 12:18:24 +0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id kALCIJ9k032283; Tue, 21 Nov 2006 13:18:19 +0100 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id kALCIFWU032280; Tue, 21 Nov 2006 13:18:15 +0100 Date: Tue, 21 Nov 2006 12:18:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] map_v4v6_address Message-ID: <20061121121815.GI3849@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00012.txt.bz2 Hi! src is const char * (and furthermore not necessarily equal to dst). I wonder if you don't want to copy to dst + 12 (or p + 12, which is the same thing) instead. 2006-10-21 Jakub Jelinek * resolv/mapv4v6addr.h (map_v4v6_address): Fix last change. --- libc/resolv/mapv4v6addr.h.jj 2006-11-21 13:08:02.000000000 +0100 +++ libc/resolv/mapv4v6addr.h 2006-11-21 13:10:02.000000000 +0100 @@ -59,7 +59,7 @@ map_v4v6_address (const char *src, char int i; /* Move the IPv4 part to the right position. */ - memcpy (src + 12, src, INADDRSZ); + memcpy (dst + 12, src, INADDRSZ); /* Mark this ipv6 addr as a mapped ipv4. */ for (i = 0; i < 10; i++) Jakub