From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9126-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 5201 invoked by alias); 30 Nov 2006 13:44:39 -0000
Received: (qmail 5183 invoked by uid 22791); 30 Nov 2006 13:44:39 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 30 Nov 2006 13:44:34 +0000
Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id kAUDiJY0011767;
	Thu, 30 Nov 2006 14:44:19 +0100
Received: (from jj@localhost)
	by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id kAUDiI2L011766;
	Thu, 30 Nov 2006 14:44:18 +0100
Date: Thu, 30 Nov 2006 13:44:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix last svc_run change
Message-ID: <20061130134418.GE9556@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20061127191041.GA3484@sunsite.mff.cuni.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061127191041.GA3484@sunsite.mff.cuni.cz>
User-Agent: Mutt/1.4.1i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00022.txt.bz2

On Mon, Nov 27, 2006 at 08:10:41PM +0100, Jakub Jelinek wrote:
> 2006-11-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	[BZ #3559]
> 	* sunrpc/svc_run.c (svc_run): Fail instead of segfaulting if
> 	malloc crashed.  Don't allocate memory unnecessarily in each
> 	loop.

Oops, brown paper bag bug in it, fixed thusly, tested with portmap:

2006-11-30  Jakub Jelinek  <jakub@redhat.com>

	* sunrpc/svc_run.c (svc_run): Set my_pollfd to new_pollfd if realloc
	succeeded.

--- libc/sunrpc/svc_run.c	27 Nov 2006 21:58:11 -0000	1.11
+++ libc/sunrpc/svc_run.c	30 Nov 2006 13:41:18 -0000
@@ -71,6 +71,7 @@ svc_run (void)
 	      break;
 	    }
 
+	  my_pollfd = new_pollfd;
 	  last_max_pollfd = max_pollfd;
 	}
 


	Jakub