From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9128-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 25548 invoked by alias); 5 Dec 2006 19:52:27 -0000
Received: (qmail 25531 invoked by uid 22791); 5 Dec 2006 19:52:26 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Dec 2006 19:52:15 +0000
Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id kB5Jq9e1029015;
	Tue, 5 Dec 2006 20:52:09 +0100
Received: (from jj@localhost)
	by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id kB5Jq9Lm029014;
	Tue, 5 Dec 2006 20:52:09 +0100
Date: Tue, 05 Dec 2006 19:52:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix nis_getnames
Message-ID: <20061205195208.GI9556@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2006-12/txt/msg00001.txt.bz2

Hi!

NIS_PATH is already in UNSECURE_ENVVARS, so ld.so unsetenv's
it during start of suid/sgid programs, so all this __secure_getenv
does is prohibit suid/sgid programs to setenv NIS_PATH to some value
and expect nis_lookup or nis_list with EXPAND_NAME flag set to use it.

2006-12-05  Jakub Jelinek  <jakub@redhat.com>

	* nis/nis_subr.c (nis_getnames): Revert last change.

--- libc/nis/nis_subr.c.jj	2006-10-19 17:26:39.000000000 +0200
+++ libc/nis/nis_subr.c	2006-12-05 20:47:11.000000000 +0100
@@ -178,7 +178,7 @@ nis_getnames (const_nis_name name)
     }
 
   /* Get the search path, where we have to search "name" */
-  path = __secure_getenv ("NIS_PATH");
+  path = getenv ("NIS_PATH");
   if (path == NULL)
     path = strdupa ("$");
   else

	Jakub