From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9138-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 16386 invoked by alias); 14 Dec 2006 17:20:20 -0000
Received: (qmail 16364 invoked by uid 22791); 14 Dec 2006 17:20:20 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Dec 2006 17:20:12 +0000
Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id kBEHKbTG004690;
	Thu, 14 Dec 2006 18:20:37 +0100
Received: (from jakub@localhost)
	by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id kBEHKaZ8004689;
	Thu, 14 Dec 2006 18:20:36 +0100
Date: Thu, 14 Dec 2006 17:20:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-pselect failure handling
Message-ID: <20061214172036.GJ3819@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2006-12/txt/msg00011.txt.bz2

Hi!

When tst-pselect.c fails (quite often when running on kernel that
doesn't have pselect6 syscall, because pselect is then not atomic,
but even 2.6.18 x86_64 kernel it fails rather quickly with pselect6
syscall when running while misc/tst-pselect; do :; done), test-skeleton.c
only kills its immediate child, while the other child sticks around
forever.

The following patch is one possibility to avoid this:

2006-12-14  Jakub Jelinek  <jakub@redhat.com>

	* misc/tst-pselect.c (do_test): Break the child loop if
	parent was killed by timeout handler.

--- libc/misc/tst-pselect.c.jj	2006-09-18 09:11:59.000000000 +0200
+++ libc/misc/tst-pselect.c	2006-12-14 16:35:33.000000000 +0100
@@ -61,12 +61,15 @@ do_test (void)
       FD_SET (fds[0][0], &rfds);
 
       int e;
+      /* Break the loop if our parent is killed by test-skeleton.c's
+	 timeout handler.  */
+      pid_t ppid = getppid ();
       do
 	{
 	  errno = 0;
 	  e = pselect (fds[0][0] + 1, &rfds, NULL, NULL, &to, &ss);
 	}
-      while (e == 0);
+      while (e == 0 && getppid () == ppid);
 
       if (e != -1)
 	{

	Jakub