From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix nscd build on ia64
Date: Sun, 18 Mar 2007 17:46:00 -0000 [thread overview]
Message-ID: <20070318175006.GT1826@sunsite.mff.cuni.cz> (raw)
Hi!
__libc_alloca_cutoff is only defined in libc.so. After the latest changes
to check_pf.c nscd fails to link on ia64, because it is not defined.
For nscd we know the stack size (at least for non-initial threads) and
limiting alloca to __MAX_ALLOCA_CUTOFF is ok.
2007-03-18 Jakub Jelinek <jakub@redhat.com>
* nscd/gai.c: Include alloca.h.
(__libc_use_alloca): Define.
--- libc/nscd/gai.c 2007-01-17 10:00:57.000000000 +0100
+++ libc/nscd/gai.c 2007-03-18 13:00:25.000000000 +0100
@@ -15,6 +15,7 @@
along with this program; if not, write to the Free Software Foundation,
Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
+#include <alloca.h>
/* This file uses the getaddrinfo code but it compiles it without NSCD
support. We just need a few symbol renames. */
#define __inet_aton inet_aton
@@ -25,6 +26,8 @@
#define __sendto sendto
#define __strchrnul strchrnul
#define __getline getline
+/* nscd uses 1MB or 2MB thread stacks. */
+#define __libc_use_alloca(size) (size <= __MAX_ALLOCA_CUTOFF)
#include <getaddrinfo.c>
Jakub
reply other threads:[~2007-03-18 17:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070318175006.GT1826@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).