From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27486 invoked by alias); 18 Mar 2007 19:02:43 -0000 Received: (qmail 27467 invoked by uid 22791); 18 Mar 2007 19:02:42 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Mar 2007 19:02:34 +0000 Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id l2IJ6jMb011227; Sun, 18 Mar 2007 20:06:45 +0100 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id l2IJ6gAc011225; Sun, 18 Mar 2007 20:06:42 +0100 Date: Sun, 18 Mar 2007 19:02:00 -0000 From: Jakub Jelinek To: Richard Henderson Cc: Glibc hackers Subject: Re: [alpha] math routine improvements Message-ID: <20070318190641.GU1826@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20070314174806.GA13985@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070314174806.GA13985@twiddle.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00029.txt.bz2 On Wed, Mar 14, 2007 at 10:48:06AM -0700, Richard Henderson wrote: > Branchless versions of some existing rounding routines. > Implement some easy functions that were missing. > Remove inline versions of fdim, because they handle inf incorrectly. Have you checked libc.so/libm.so ABI before/after the patch (I'm using: for i in `find . -name '*.so*' -a -type f`; do readelf -Ws $i \ | sed -n '/\.symtab/,$d;/ UND /d;/@GLIBC_PRIVATE/d;/\(GLOBAL\|WEAK\)/p' \ | awk '{ if ($4 == "OBJECT") { printf "%s %s %s %s %s\n", $8, $4, $5, $6, $3 } else { printf "%s %s %s %s\n", $8, $4, $5, $6 }}' \ | LC_ALL=C sort -u > ~/xxabilist/$1-$2-$3/$b/`echo $i | sed 's|^\./||;s|/|.|g'`.abi done and then diff the files)? >From a quick glance at the new files and math/Versions and/or sysdeps/ldbl-opt/ compat_symbol versions I'd say following is needed, but it is untested. 2007-03-18 Jakub Jelinek * sysdeps/alpha/fpu/s_nearbyint.c (nearbyintl): Fix version on compat_symbol to GLIBC_2_1. * sysdeps/alpha/fpu/s_fmin.S (fminl): Likewise. * sysdeps/alpha/fpu/s_trunc.c (truncl): Likewise. * sysdeps/alpha/fpu/s_fmax.S (fmaxl): Likewise. * sysdeps/alpha/fpu/s_lrint.c (lrintl, llrintl): Likewise. * sysdeps/alpha/fpu/s_lround.c (lroundl, llroundl): Likewise. * sysdeps/alpha/fpu/s_round.c (roundl): Likewise. * sysdeps/alpha/fpu/s_isnan.c (isnanl): Provide compat_symbol in libc, not libm. (__isnanl): New compat_symbol. --- libc/sysdeps/alpha/fpu/s_nearbyint.c.jj 2007-03-14 18:44:14.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_nearbyint.c 2007-03-18 19:25:04.000000000 +0100 @@ -43,6 +43,6 @@ weak_alias (__nearbyint, nearbyint) strong_alias (__nearbyint, __nearbyintl) weak_alias (__nearbyint, nearbyintl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __nearbyint, nearbyintl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __nearbyint, nearbyintl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_isnan.c.jj 2007-03-14 18:44:14.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_isnan.c 2007-03-18 19:27:46.000000000 +0100 @@ -53,6 +53,9 @@ weak_alias (__isnanf, isnanf) strong_alias (__isnan, __isnanl) weak_alias (__isnan, isnanl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __isnan, isnanl, GLIBC_2_0); +#ifndef IS_IN_libm +# if LONG_DOUBLE_COMPAT(libc, GLIBC_2_0) +compat_symbol (libc, __isnan, __isnanl, GLIBC_2_0); +compat_symbol (libc, isnan, isnanl, GLIBC_2_0); +# endif #endif --- libc/sysdeps/alpha/fpu/s_fmin.S.jj 2007-03-14 18:44:14.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_fmin.S 2007-03-18 19:28:09.000000000 +0100 @@ -53,6 +53,6 @@ weak_alias (__fmin, fmin) strong_alias (__fmin, __fminl) weak_alias (__fminl, fminl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __fmin, fminl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __fmin, fminl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_trunc.c.jj 2007-03-14 21:01:05.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_trunc.c 2007-03-18 19:24:22.000000000 +0100 @@ -48,6 +48,6 @@ weak_alias (__trunc, trunc) strong_alias (__trunc, __truncl) weak_alias (__trunc, truncl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __trunc, truncl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __trunc, truncl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_fmax.S.jj 2007-03-14 18:44:14.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_fmax.S 2007-03-18 19:28:20.000000000 +0100 @@ -53,6 +53,6 @@ weak_alias (__fmax, fmax) strong_alias (__fmax, __fmaxl) weak_alias (__fmaxl, fmaxl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __fmax, fmaxl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __fmax, fmaxl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_lrint.c.jj 2007-03-14 18:44:14.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_lrint.c 2007-03-18 19:26:07.000000000 +0100 @@ -42,7 +42,7 @@ strong_alias (__lrint, __llrintl) weak_alias (__lrintl, lrintl) weak_alias (__llrintl, llrintl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __lrint, lrintl, GLIBC_2_0); -compat_symbol (libm, __llrint, llrintl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __lrint, lrintl, GLIBC_2_1); +compat_symbol (libm, __llrint, llrintl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_lround.c.jj 2007-03-14 21:01:05.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_lround.c 2007-03-18 19:25:43.000000000 +0100 @@ -42,7 +42,7 @@ strong_alias (__lround, __llroundl) weak_alias (__lroundl, lroundl) weak_alias (__llroundl, llroundl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __lround, lroundl, GLIBC_2_0); -compat_symbol (libm, __llround, llroundl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __lround, lroundl, GLIBC_2_1); +compat_symbol (libm, __llround, llroundl, GLIBC_2_1); #endif --- libc/sysdeps/alpha/fpu/s_round.c.jj 2007-03-14 21:01:05.000000000 +0100 +++ libc/sysdeps/alpha/fpu/s_round.c 2007-03-18 19:24:40.000000000 +0100 @@ -44,6 +44,6 @@ weak_alias (__round, round) strong_alias (__round, __roundl) weak_alias (__roundl, roundl) #endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) -compat_symbol (libm, __round, roundl, GLIBC_2_0); +#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) +compat_symbol (libm, __round, roundl, GLIBC_2_1); #endif Jakub