From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9214-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 16330 invoked by alias); 5 Apr 2007 02:27:49 -0000
Received: (qmail 16314 invoked by uid 22791); 5 Apr 2007 02:27:49 -0000
X-Spam-Check-By: sourceware.org
Received: from are.twiddle.net (HELO are.twiddle.net) (64.81.246.98)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Apr 2007 03:27:44 +0100
Received: from are.twiddle.net (localhost.localdomain [127.0.0.1])
	by are.twiddle.net (8.13.8/8.13.6) with ESMTP id l352QueJ029851;
	Wed, 4 Apr 2007 19:26:56 -0700
Received: (from rth@localhost)
	by are.twiddle.net (8.13.8/8.13.8/Submit) id l352QtM4029850;
	Wed, 4 Apr 2007 19:26:55 -0700
Date: Thu, 05 Apr 2007 02:27:00 -0000
From: Richard Henderson <rth@twiddle.net>
To: Steven Munroe <munroesj@us.ibm.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
        Glibc hackers <libc-hacker@sources.redhat.com>,
        Ulrich Drepper <drepper@redhat.com>,
        Peter Eberlein <eberlein@us.ibm.com>
Subject: Re: [PATCH] PPC fenv fixes.
Message-ID: <20070405022655.GA29766@twiddle.net>
Mail-Followup-To: Steven Munroe <munroesj@us.ibm.com>,
	Jakub Jelinek <jakub@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Peter Eberlein <eberlein@us.ibm.com>
References: <20070322145345.GZ1826@sunsite.mff.cuni.cz> <4602FCE5.7060203@us.ibm.com> <460941B8.2050501@us.ibm.com> <20070327160708.GA355@devserv.devel.redhat.com> <46096124.6050504@us.ibm.com> <460A8D78.6060303@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <460A8D78.6060303@us.ibm.com>
User-Agent: Mutt/1.4.2.1i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00003.txt.bz2

On Wed, Mar 28, 2007 at 10:44:56AM -0500, Steven Munroe wrote:
>     performance penalty (but have no other visible effect).  */
>  extern const fenv_t *__fe_nomask_env (void);
>  # define FE_NOMASK_ENV	(__fe_nomask_env ())
> +
> +/* Floating-point environment with all exceptions disabled.  */
> +extern const fenv_t *__fe_mask_env (void);
> +# define FE_MASK_ENV	(__fe_mask_env ())

This is incorrect.  The mere evaluation of FE_NOMASK_ENV/FE_MASK_ENV
should have no effect at all.  This stuff should be delayed until
the environment is actually installed.

You should be using magic numbers, like in the i386 port.


r~