From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9232-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 19983 invoked by alias); 9 May 2007 06:47:20 -0000
Received: (qmail 19961 invoked by uid 22791); 9 May 2007 06:47:19 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 May 2007 06:47:15 +0000
Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id l496th5u031962;
	Wed, 9 May 2007 08:55:43 +0200
Received: (from jakub@localhost)
	by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id l496tgVe031961;
	Wed, 9 May 2007 08:55:42 +0200
Date: Wed, 09 May 2007 06:47:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix ia64 feraiseexcept (take 2)
Message-ID: <20070509065542.GB1826@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20070508213815.GA1826@sunsite.mff.cuni.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070508213815.GA1826@sunsite.mff.cuni.cz>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2007-05/txt/msg00006.txt.bz2

On Tue, May 08, 2007 at 11:38:15PM +0200, Jakub Jelinek wrote:
> While feraiseexcept (FE_OVERFLOW); or feraiseexcept (FE_UNDERFLOW) are
> allowed to raise additionally inexact exception, feraiseexcept (FE_INEXACT)
> shouldn't raise any exception but inexact.
> 
> DBL_MAX + 1.0 overflows and is inexact though, while (DBL_MAX / 2.0) + 1.0
> is only inexact, but doesn't overflow.

Small correction, feraiseexcept without the patch misbehaves with fesetround
(FE_UPWARD) only, but IMHO it should be fixed even for that case.
Another alternative is to subtract f1 from DBL_MAX rather than add it,
which has the advantage that only 2 double constants are in .sdata rather
than 3 as with previous patch.

2007-05-09  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ia64/fpu/fraiseexcpt.c (feraiseexcept): Don't raise overflow
	exception in addition to inexact when asked to raise only FE_INEXACT.

--- libc/sysdeps/ia64/fpu/fraiseexcpt.c.jj	2003-11-29 08:28:46.000000000 +0100
+++ libc/sysdeps/ia64/fpu/fraiseexcpt.c	2007-05-09 08:38:43.000000000 +0200
@@ -1,5 +1,6 @@
 /* Raise given exceptions.
-   Copyright (C) 1997, 1998, 2000, 2001, 2002 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1998, 2000, 2001, 2002, 2007
+   Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Jes Sorensen <Jes.Sorensen@cern.ch>, 2000.
 
@@ -70,7 +71,7 @@ feraiseexcept (int excepts)
   if (FE_INEXACT & excepts)
     {
       dummy = DBL_MAX;
-      __asm__ __volatile__ ("fadd.d.s0 %0=%1,f1" : "=f" (dummy) : "0" (dummy));
+      __asm__ __volatile__ ("fsub.d.s0 %0=%1,f1" : "=f" (dummy) : "0" (dummy));
     }
 
   /* Success.  */

	Jakub