From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10327 invoked by alias); 28 May 2007 13:49:10 -0000 Received: (qmail 10280 invoked by uid 22791); 28 May 2007 13:49:09 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 May 2007 13:49:08 +0000 Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id l4SDpCth025511; Mon, 28 May 2007 15:51:12 +0200 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id l4SDpC61025510; Mon, 28 May 2007 15:51:12 +0200 Date: Mon, 28 May 2007 13:49:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Misc small warning fixes Message-ID: <20070528135112.GK3081@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00027.txt.bz2 Hi! When __NR_utimensat is not defined, gcc warns about miss_utimensat being defined, but never used. And without the second hunk __getpagesize is implicitly prototyped in PPCs pthread_attr_setstacksize. 2007-05-28 Jakub Jelinek * sysdeps/unix/sysv/linux/futimes.c (miss_utimensat): Don't define if __NR_utimensat is not defined. * sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c: Include unistd.h. --- libc/sysdeps/unix/sysv/linux/futimes.c.jj 2007-05-28 15:07:37.000000000 +0200 +++ libc/sysdeps/unix/sysv/linux/futimes.c 2007-05-28 15:07:37.000000000 +0200 @@ -1,5 +1,5 @@ /* futimes -- change access and modification times of open file. Linux version. - Copyright (C) 2002,2003,2005,2006 Free Software Foundation, Inc. + Copyright (C) 2002,2003,2005,2006,2007 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -29,7 +29,7 @@ #include -#ifndef __ASSUME_UTIMENSAT +#if defined __NR_utimensat && !defined __ASSUME_UTIMENSAT static int miss_utimensat; #endif --- libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c.jj 2006-10-07 21:51:33.000000000 +0200 +++ libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c 2007-05-28 15:16:12.000000000 +0200 @@ -1,3 +1,4 @@ +#include /* For __getpagesize. */ #define NEW_VERNUM GLIBC_2_6 #define STACKSIZE_ADJUST \ do { \ Jakub