From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix pthread_getattr_np
Date: Fri, 22 Jun 2007 10:05:00 -0000 [thread overview]
Message-ID: <20070622100947.GE3081@sunsite.mff.cuni.cz> (raw)
Hi!
My reading of pthread_getattr_np is that following code will crash:
pthread_attr_t attr;
memset (&attr, 0xaa, sizeof (attr)); // Stress that attr is uninitialized
if (pthread_getattr_np (pthread_self (), &attr) == 0)
pthread_attr_destroy (&attr);
if sched_getaffinity returns ENOSYS.
One way to fix this is below, another would be e.g. to clear whole
pthread_attr_t at the start of pthread_getattr_np. That could cure even
crashes on invalid careless code like e.g. boehm-gc does:
my_pthread = pthread_self();
pthread_getattr_np (my_pthread, &attr);
pthread_attr_getstack (&attr, (void **) &stack_addr, &stack_size);
pthread_attr_destroy (&attr);
(which has to be fixed anyway).
2007-06-22 Jakub Jelinek <jakub@redhat.com>
* pthread_getattr_np.c (pthread_getattr_np): Clear cpuset and
cpusetsize if pthread_getaffinity_np failed with ENOSYS.
--- libc/nptl/pthread_getattr_np.c.jj 2007-06-04 08:42:05.000000000 +0200
+++ libc/nptl/pthread_getattr_np.c 2007-06-22 11:41:48.000000000 +0200
@@ -164,8 +164,12 @@ pthread_getattr_np (thread_id, attr)
{
free (cpuset);
if (ret == ENOSYS)
- /* There is no such functionality. */
- ret = 0;
+ {
+ /* There is no such functionality. */
+ ret = 0;
+ iattr->cpuset = NULL;
+ iattr->cpusetsize = 0;
+ }
}
}
Jakub
next reply other threads:[~2007-06-22 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 10:05 Jakub Jelinek [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-03-22 18:16 Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622100947.GE3081@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).