From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11382 invoked by alias); 6 Jul 2007 21:55:04 -0000 Received: (qmail 11366 invoked by uid 22791); 6 Jul 2007 21:55:04 -0000 X-Spam-Check-By: sourceware.org Received: from mo11.iij4u.or.jp (HELO mo11.iij4u.or.jp) (210.138.174.79) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jul 2007 21:54:59 +0000 Received: by mo.iij4u.or.jp (mo11) id l66Lst5M004488; Sat, 7 Jul 2007 06:54:55 +0900 Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238]) by mbox.iij4u.or.jp (mbox11) id l66LsrOC021252; Sat, 7 Jul 2007 06:54:53 +0900 Date: Fri, 06 Jul 2007 21:55:00 -0000 Message-Id: <20070707.065436.35682509.kkojima@rr.iij4u.or.jp> To: libc-hacker@sources.redhat.com Subject: [PATCH] check_pf.c: Include alloca.h From: Kaz Kojima X-Mailer: Mew version 3.3 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00004.txt.bz2 I've tried the build with gcc-4.2 for SH and got an error like xsh-libc-gcc4/libc.so.6: undefined reference to `__libc_use_alloca' It seems that the undefined reference happens on check_pf.os. Currently sysdeps/unix/sysv/linux/check_pf.c uses alloca without including alloca.h. Although this is not a problem on x86 because alloca.h is included indirectly on that architecture, it looks that other users of alloca function include alloca.h explicitly. How about the attached one-liner? Regards, kaz -- 2007-07-06 Kaz Kojima * sysdeps/unix/sysv/linux/check_pf.c: Include alloca.h. --- ORIG/libc/sysdeps/unix/sysv/linux/check_pf.c 2007-06-18 09:03:48.000000000 +0900 +++ LOCAL/libc/sysdeps/unix/sysv/linux/check_pf.c 2007-07-04 09:13:50.000000000 +0900 @@ -25,6 +25,7 @@ #include #include #include +#include #include #include