public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>
Cc: libc-hacker@sources.redhat.com
Subject: Re: [PATCH] Fix realloc prototype (BZ #4792)
Date: Mon, 16 Jul 2007 11:15:00 -0000	[thread overview]
Message-ID: <20070716111733.GQ4603@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <20070716102947.24376.qmail@md.dent.med.uni-muenchen.de>

On Mon, Jul 16, 2007 at 10:29:47AM -0000, Wolfram Gloger wrote:
> > 2007-07-16  Jakub Jelinek  <jakub@redhat.com>
> > 
> > 	[BZ #4792]
> > 	* stdlib/stdlib.h (realloc): Remove __attribute_malloc__.
> > 	* malloc/malloc.h (realloc): Likewise.
> 
> Based on the argument above, I disagree with this change.

Except that this is highly controversial in GCC apparently, various
GCC developers have different opinions on this and that also exhibits
in the optimizations GCC will do with malloc attribute.

> Within gcc, I guess you are referring to:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32748

I'm not actually refering to that, but e.g. to the "add alloc_size attribute"
gcc-patches thread back this May, or to the longish 2004 thread.
If GCC has realloc attribute, then glibc should use it, until then
it is certainly safer not to use malloc attribute.

	Jakub

      reply	other threads:[~2007-07-16 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16  9:58 Jakub Jelinek
2007-07-16 10:30 ` Wolfram Gloger
2007-07-16 11:15   ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716111733.GQ4603@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=wmglo@dent.med.uni-muenchen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).