From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27786 invoked by alias); 16 Jul 2007 12:18:48 -0000 Received: (qmail 27766 invoked by uid 22791); 16 Jul 2007 12:18:47 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 16 Jul 2007 12:18:44 +0000 Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id l6GCM9FK001272; Mon, 16 Jul 2007 14:22:09 +0200 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id l6GCM95t001270; Mon, 16 Jul 2007 14:22:09 +0200 Date: Mon, 16 Jul 2007 12:18:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: Re: [PATCH] Fix LC_TIME in ar_SA and dz_BT locales Message-ID: <20070716122209.GS4603@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20070716112551.GR4603@sunsite.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070716112551.GR4603@sunsite.mff.cuni.cz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00022.txt.bz2 On Mon, Jul 16, 2007 at 01:25:51PM +0200, Jakub Jelinek wrote: > These 2 locales contain invalid strftime conversion modifiers. E.g. > LC_ALL=ar_SA.UTF-8 date +%c > shows %.1d and %.1H in the string where one would expect day and hour, > LC_ALL=dz_BT.UTF-8 date +%X > shows % H and doesn't display hour anywhere. Actually, %.1d -> %e and %.1H -> %k might be a better idea, guess that's almost what that meant (not sure if the padding is acceptable or not, but we don't support %.1{d,H}, so this is certainly an improvement over what we had). 2007-07-16 Jakub Jelinek * locales/ar_SA (d_t_fmt, d_fmt, t_fmt, t_fmt_ampm): Replace %.1d with supported %e and %.1H with %k. * locales/dz_BT (t_fmt): Remove whitespace between % and H. --- libc/localedata/locales/ar_SA.jj 2006-07-31 00:19:44.000000000 +0200 +++ libc/localedata/locales/ar_SA 2007-07-16 12:19:29.000000000 +0200 @@ -294,16 +294,16 @@ END LC_NUMERIC % Set up the LC_TIME category -% d_t_fmt "%A %.1d %B %Y %.1H:%M:%S" -% d_fmt "%A %.1d %B %Y" -% t_fmt "%.1H:%M:%S" -% t_fmt_ampm "%.1H:%M:%S" +% d_t_fmt "%A %e %B %Y %k:%M:%S" +% d_fmt "%A %e %B %Y" +% t_fmt "%k:%M:%S" +% t_fmt_ampm "%k:%M:%S" LC_TIME -d_t_fmt "" -d_fmt "" -t_fmt "" -t_fmt_ampm "" +d_t_fmt "" +d_fmt "" +t_fmt "" +t_fmt_ampm "" day ""; / ""; / ""; / --- libc/localedata/locales/dz_BT.jj 2006-07-31 00:19:44.000000000 +0200 +++ libc/localedata/locales/dz_BT 2007-07-16 12:14:16.000000000 +0200 @@ -1293,7 +1293,7 @@ d_fmt "/ -% H/ +%H/ %M%S" % AM/PM signs Jakub