From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17620 invoked by alias); 13 Aug 2007 14:56:22 -0000 Received: (qmail 17559 invoked by uid 22791); 13 Aug 2007 14:56:20 -0000 X-Spam-Check-By: sourceware.org Received: from mo11.iij4u.or.jp (HELO mo11.iij4u.or.jp) (210.138.174.79) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 14:56:11 +0000 Received: by mo.iij4u.or.jp (mo11) id l7DEu8VJ002955; Mon, 13 Aug 2007 23:56:08 +0900 Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238]) by mbox.iij4u.or.jp (mbox10) id l7DEu7tO015923; Mon, 13 Aug 2007 23:56:07 +0900 Date: Mon, 13 Aug 2007 14:56:00 -0000 Message-Id: <20070813.235606.54189794.kkojima@rr.iij4u.or.jp> To: libc-hacker@sources.redhat.com Subject: About stdlib/strto* change From: Kaz Kojima X-Mailer: Mew version 3.3 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00015.txt.bz2 Hi, There is a build failure for SH during compiling stdlib/strtold_l.c: strtold_l.c:61: error: 'strtold_l' aliased to undefined symbol '__strtold_l' In Aug 6 Roland's change, libc_hidden_proto (__strtold_l) is added to include/stdlib.h and weak_alias (__STRTOLD, STRTOLD) is added to stdlib/strtold_l.c. It seems that libc_hedden_def is needed also for __strtold_l just before the above weak_alias statement. Is it right? x86 uses sysdeps/ieee754/ldbl-96/strtold_l.c which includes stdlib/strtod_l.c instead of stdlib/strtold_l.c and the corresponding libc_hedden_def was added to stdlib/strtod_l.c at that time. The attached patch works for me, though I suspect that I've missed something. Regards, kaz -- * stdlib/strtold.c: Add libc_hidden_def. --- ORIG/libc/stdlib/strtold_l.c 2005-12-14 20:14:13.000000000 +0900 +++ LOCAL/libc/stdlib/strtold_l.c 2007-08-13 20:43:24.000000000 +0900 @@ -1,4 +1,4 @@ -/* Copyright (C) 1999, 2002, 2004 Free Software Foundation, Inc. +/* Copyright (C) 1999, 2002, 2004, 2007 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -55,4 +55,7 @@ __STRTOLD (const STRING_TYPE *nptr, STRI { return INTERNAL (__STRTOD) (nptr, endptr, 0, loc); } +#if defined _LIBC && !defined USE_WIDE_CHAR +libc_hidden_def (__STRTOLD) +#endif weak_alias (__STRTOLD, STRTOLD)