From: Jakub Jelinek <jakub@redhat.com>
To: Kaz Kojima <kkojima@rr.iij4u.or.jp>
Cc: libc-hacker@sources.redhat.com
Subject: Re: About stdlib/strto* change
Date: Mon, 13 Aug 2007 15:28:00 -0000 [thread overview]
Message-ID: <20070813153353.GP4603@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <20070813.235606.54189794.kkojima@rr.iij4u.or.jp>
On Mon, Aug 13, 2007 at 11:56:06PM +0900, Kaz Kojima wrote:
> There is a build failure for SH during compiling stdlib/strtold_l.c:
>
> strtold_l.c:61: error: 'strtold_l' aliased to undefined symbol '__strtold_l'
>
> In Aug 6 Roland's change, libc_hidden_proto (__strtold_l) is added
> to include/stdlib.h and weak_alias (__STRTOLD, STRTOLD) is added to
> stdlib/strtold_l.c. It seems that libc_hedden_def is needed also
> for __strtold_l just before the above weak_alias statement. Is it
> right? x86 uses sysdeps/ieee754/ldbl-96/strtold_l.c which includes
> stdlib/strtod_l.c instead of stdlib/strtold_l.c and the corresponding
> libc_hedden_def was added to stdlib/strtod_l.c at that time.
> The attached patch works for me, though I suspect that I've missed
> something.
I believe you should match what has been added to strtod_l.c, i.e.:
{
return INTERNAL (__STRTOD) (nptr, endptr, 0, loc);
}
+#if defined _LIBC
+libc_hidden_def (__STRTOLD)
+libc_hidden_ver (__STRTOLD, STRTOLD)
+#endif
weak_alias (__STRTOLD, STRTOLD)
otherwise calls to strtold_l from within libc.so will go through
PLT. stdlib/strtold_l.c is only used on
sizeof (double) == sizeof (long double) arches, which I'm afraid
I don't have access to any.
Jakub
next prev parent reply other threads:[~2007-08-13 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 14:56 Kaz Kojima
2007-08-13 15:28 ` Jakub Jelinek [this message]
2007-08-13 15:45 ` Kaz Kojima
2007-08-13 15:54 ` Jakub Jelinek
2007-08-13 22:11 ` Kaz Kojima
2007-08-14 14:37 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070813153353.GP4603@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=kkojima@rr.iij4u.or.jp \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).