From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9349-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 12724 invoked by alias); 13 Aug 2007 15:45:11 -0000
Received: (qmail 12681 invoked by uid 22791); 13 Aug 2007 15:45:10 -0000
X-Spam-Check-By: sourceware.org
Received: from mo11.iij4u.or.jp (HELO mo11.iij4u.or.jp) (210.138.174.79)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 15:44:58 +0000
Received: by mo.iij4u.or.jp (mo11) id l7DFilPq013792; Tue, 14 Aug 2007 00:44:47 +0900
Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238])
	by mbox.iij4u.or.jp (mbox10) id l7DFij7N007614;
	Tue, 14 Aug 2007 00:44:46 +0900
Date: Mon, 13 Aug 2007 15:45:00 -0000
Message-Id: <20070814.004445.35509960.kkojima@rr.iij4u.or.jp>
To: jakub@redhat.com
Cc: libc-hacker@sources.redhat.com
Subject: Re: About stdlib/strto* change
From: Kaz Kojima <kkojima@rr.iij4u.or.jp>
In-Reply-To: <20070813153353.GP4603@sunsite.mff.cuni.cz>
References: <20070813.235606.54189794.kkojima@rr.iij4u.or.jp>
	<20070813153353.GP4603@sunsite.mff.cuni.cz>
X-Mailer: Mew version 3.3 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00018.txt.bz2

Jakub Jelinek <jakub@redhat.com> wrote:
> I believe you should match what has been added to strtod_l.c, i.e.:
>  {
>    return INTERNAL (__STRTOD) (nptr, endptr, 0, loc);
>  }
> +#if defined _LIBC
> +libc_hidden_def (__STRTOLD)
> +libc_hidden_ver (__STRTOLD, STRTOLD)
> +#endif
>  weak_alias (__STRTOLD, STRTOLD)
> 
> otherwise calls to strtold_l from within libc.so will go through
> PLT.  stdlib/strtold_l.c is only used on
> sizeof (double) == sizeof (long double) arches, which I'm afraid
> I don't have access to any.

I've tried your patch and got

In file included from wcstold_l.c:32:
../stdlib/strtold_l.c:60: error: 'wcstold_l' undeclared here (not in a function)../stdlib/strtold_l.c:60: warning: type defaults to 'int' in declaration of '__EI_wcstold_l'
../stdlib/strtold_l.c:60: warning: type defaults to 'int' in declaration of '__EI_wcstold_l'

So perhaps, is the patch

 {
   return INTERNAL (__STRTOD) (nptr, endptr, 0, loc);
 }
+#if defined _LIBC && !defined USE_WIDE_CHAR
+libc_hidden_def (__STRTOLD)
+libc_hidden_ver (__STRTOLD, STRTOLD)
+#endif
 weak_alias (__STRTOLD, STRTOLD)

ok?

Regards,
	kaz