From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30096 invoked by alias); 13 Aug 2007 22:11:33 -0000 Received: (qmail 29969 invoked by uid 22791); 13 Aug 2007 22:11:30 -0000 X-Spam-Check-By: sourceware.org Received: from mo10.iij4u.or.jp (HELO mo10.iij4u.or.jp) (210.138.174.78) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 22:11:23 +0000 Received: by mo.iij4u.or.jp (mo10) id l7DMBCDh017947; Tue, 14 Aug 2007 07:11:12 +0900 Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238]) by mbox.iij4u.or.jp (mbox11) id l7DMBBBW008945; Tue, 14 Aug 2007 07:11:11 +0900 Date: Mon, 13 Aug 2007 22:11:00 -0000 Message-Id: <20070814.071111.71554587.kkojima@rr.iij4u.or.jp> To: Jakub Jelinek Cc: Ulrich Drepper , libc-hacker@sources.redhat.com Subject: Re: About stdlib/strto* change From: Kaz Kojima In-Reply-To: <20070813160013.GQ4603@sunsite.mff.cuni.cz> References: <20070813153353.GP4603@sunsite.mff.cuni.cz> <20070814.004445.35509960.kkojima@rr.iij4u.or.jp> <20070813160013.GQ4603@sunsite.mff.cuni.cz> X-Mailer: Mew version 3.3 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00021.txt.bz2 Jakub Jelinek wrote: >> In file included from wcstold_l.c:32: >> ../stdlib/strtold_l.c:60: error: 'wcstold_l' undeclared here (not in a function)../stdlib/strtold_l.c:60: warning: type defaults to 'int' in declaration of '__EI_wcstold_l' >> ../stdlib/strtold_l.c:60: warning: type defaults to 'int' in declaration of '__EI_wcstold_l' > > Either stdlib/strtold_l.c, or wcsmbs/wcstold_l.c then needs to > #include Ah, I see. With copying #if defined _LIBC || defined HAVE_WCHAR_H # include #endif lines from stdlib/strtod_l.c to strtold_l.c, the error went away. Thanks for your suggenstions! The attached patch is the revised one. Uli, does it look Ok? -- 2007-08-13 Kaz Kojima * stdlib/strtold_l.c: Include wchar.h if needed. Add libc_hidden_def. --- ORIG/libc/stdlib/strtold_l.c 2005-12-14 20:14:13.000000000 +0900 +++ LOCAL/libc/stdlib/strtold_l.c 2007-08-14 06:50:14.000000000 +0900 @@ -1,4 +1,4 @@ -/* Copyright (C) 1999, 2002, 2004 Free Software Foundation, Inc. +/* Copyright (C) 1999, 2002, 2004, 2007 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -20,6 +20,10 @@ #include #include +#if defined _LIBC || defined HAVE_WCHAR_H +# include +#endif + #ifdef USE_WIDE_CHAR # define STRING_TYPE wchar_t # define STRTOLD wcstold_l @@ -55,4 +59,8 @@ __STRTOLD (const STRING_TYPE *nptr, STRI { return INTERNAL (__STRTOD) (nptr, endptr, 0, loc); } +#if defined _LIBC +libc_hidden_def (__STRTOLD) +libc_hidden_ver (__STRTOLD, STRTOLD) +#endif weak_alias (__STRTOLD, STRTOLD)