public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>, Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix checking of ld.so undefined symbols on sparc64
Date: Thu, 16 Aug 2007 20:13:00 -0000	[thread overview]
Message-ID: <20070816201927.GC2279@sunsite.mff.cuni.cz> (raw)

Hi!

The nm -u ld.so | cmp -s /dev/null -
test fails on sparc64, because ld.so (and other shared libs) on sparc64
have STT_REGISTER SHN_UNDEF symbols which are supposed to be undefined
per psABI and are not really any kind of errors, just notes about
each library's use of global registers.
Using readelf -s allows us to filter symbols which can be SHN_UNDEF
(symbol 0 and STT_REGISTER).
Ok?

2007-08-16  Jakub Jelinek  <jakub@redhat.com>

	* elf/Makefile ($(objpfx)ld.so): Use readelf -s and awk instead of nm -u
	to check for undefined symbols.

--- libc/elf/Makefile.jj	2007-08-10 15:31:49.000000000 +0200
+++ libc/elf/Makefile	2007-08-16 22:08:21.000000000 +0200
@@ -307,7 +307,9 @@ $(objpfx)ld.so: $(objpfx)librtld.os $(ld
 		  $(filter-out $(map-file),$^) $(load-map-file)		\
 		  -Wl,-soname=$(rtld-installed-name) -T $@.lds
 	rm -f $@.lds
-	nm -u $@ | cmp -s /dev/null -
+	readelf -s $@ \
+	  | awk '($7 ~ /^UND(|EF)$/ && $1 != "0:" && $4 != "REGISTER") { print }' \
+	  | cmp -s /dev/null -
 
 # interp.c exists just to get this string into the libraries.
 CFLAGS-interp.c = -D'RUNTIME_LINKER="$(slibdir)/$(rtld-installed-name)"' \

	Jakub

             reply	other threads:[~2007-08-16 20:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16 20:13 Jakub Jelinek [this message]
2007-08-16 20:23 ` Roland McGrath
2007-08-16 20:28   ` Jakub Jelinek
2007-08-16 21:17     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816201927.GC2279@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).