From: Roland McGrath <roland@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Re: Testsuite failure in check-localplt
Date: Mon, 08 Oct 2007 21:10:00 -0000 [thread overview]
Message-ID: <20071008211011.C1E9E4D04CC@magilla.localdomain> (raw)
In-Reply-To: Andreas Jaeger's message of Monday, 8 October 2007 21:33:10 +0200 <m3ve9hbdvt.fsf@gromit.moeb>
Look for the relocs in libc.so that refer to those symbols. Probably they
should be calling __read, which already has libc_hidden_proto. If they are
in code never reached by ISO C-only, then they could legitimately stick to
read for aesthetic purposes if one really cared, but then you'd need to add
libc_hidden_proto for read in include/unistd.h, which we haven't needed yet.
(If they are in low-level linux-specific code, they might want to be using
INLINE_SYSCALL anyway.)
Thanks,
Roland
next prev parent reply other threads:[~2007-10-08 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 19:33 Andreas Jaeger
2007-10-08 21:10 ` Roland McGrath [this message]
2007-10-09 5:50 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008211011.C1E9E4D04CC@magilla.localdomain \
--to=roland@redhat.com \
--cc=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).