From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Shut up -Wstrict-aliasing warnings with pthread_cleanup_push in g++ -fno-exceptions
Date: Tue, 20 Nov 2007 22:36:00 -0000 [thread overview]
Message-ID: <20071120223923.GA5054@sunsite.mff.cuni.cz> (raw)
Hi!
See https://bugzilla.redhat.com/show_bug.cgi?id=381411
g++ 4.1 and 4.2 -Wstrict-aliasing warnings is sometimes more verbose than it
should, struct __jmp_buf_tag has just forward decl and so g++ decides to
warn just in case. The extra cast shuts this up and doesn't harm the code
(for obscure compilation mode which should never be really used with
pthread_cancel and the cleanup macros anyway).
2007-11-20 Jakub Jelinek <jakub@redhat.com>
* sysdeps/pthread/pthread.h (pthread_cleanup_push,
pthread_cleanup_push_defer_np): Add extra (void *) cast to shut up
g++ 4.1 and 4.2 -Wstrict-aliasing warnings.
--- libc/nptl/sysdeps/pthread/pthread.h.jj 2007-06-04 08:42:06.000000000 +0200
+++ libc/nptl/sysdeps/pthread/pthread.h 2007-11-20 23:28:21.000000000 +0100
@@ -638,7 +638,7 @@ __pthread_cleanup_routine (struct __pthr
__pthread_unwind_buf_t __cancel_buf; \
void (*__cancel_routine) (void *) = (routine); \
void *__cancel_arg = (arg); \
- int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \
+ int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \
__cancel_buf.__cancel_jmp_buf, 0); \
if (__builtin_expect (not_first_call, 0)) \
{ \
@@ -672,7 +672,7 @@ extern void __pthread_unregister_cancel
__pthread_unwind_buf_t __cancel_buf; \
void (*__cancel_routine) (void *) = (routine); \
void *__cancel_arg = (arg); \
- int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \
+ int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \
__cancel_buf.__cancel_jmp_buf, 0); \
if (__builtin_expect (not_first_call, 0)) \
{ \
Jakub
reply other threads:[~2007-11-20 22:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120223923.GA5054@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).