From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24515 invoked by alias); 20 Nov 2007 22:36:03 -0000 Received: (qmail 24499 invoked by uid 22791); 20 Nov 2007 22:36:03 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Nov 2007 22:35:59 +0000 Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id lAKMdOWg013985; Tue, 20 Nov 2007 23:39:24 +0100 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id lAKMdOUQ013984; Tue, 20 Nov 2007 23:39:24 +0100 Date: Tue, 20 Nov 2007 22:36:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Shut up -Wstrict-aliasing warnings with pthread_cleanup_push in g++ -fno-exceptions Message-ID: <20071120223923.GA5054@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00002.txt.bz2 Hi! See https://bugzilla.redhat.com/show_bug.cgi?id=381411 g++ 4.1 and 4.2 -Wstrict-aliasing warnings is sometimes more verbose than it should, struct __jmp_buf_tag has just forward decl and so g++ decides to warn just in case. The extra cast shuts this up and doesn't harm the code (for obscure compilation mode which should never be really used with pthread_cancel and the cleanup macros anyway). 2007-11-20 Jakub Jelinek * sysdeps/pthread/pthread.h (pthread_cleanup_push, pthread_cleanup_push_defer_np): Add extra (void *) cast to shut up g++ 4.1 and 4.2 -Wstrict-aliasing warnings. --- libc/nptl/sysdeps/pthread/pthread.h.jj 2007-06-04 08:42:06.000000000 +0200 +++ libc/nptl/sysdeps/pthread/pthread.h 2007-11-20 23:28:21.000000000 +0100 @@ -638,7 +638,7 @@ __pthread_cleanup_routine (struct __pthr __pthread_unwind_buf_t __cancel_buf; \ void (*__cancel_routine) (void *) = (routine); \ void *__cancel_arg = (arg); \ - int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \ + int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \ __cancel_buf.__cancel_jmp_buf, 0); \ if (__builtin_expect (not_first_call, 0)) \ { \ @@ -672,7 +672,7 @@ extern void __pthread_unregister_cancel __pthread_unwind_buf_t __cancel_buf; \ void (*__cancel_routine) (void *) = (routine); \ void *__cancel_arg = (arg); \ - int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \ + int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \ __cancel_buf.__cancel_jmp_buf, 0); \ if (__builtin_expect (not_first_call, 0)) \ { \ Jakub