From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16087 invoked by alias); 7 Nov 2008 12:34:58 -0000 Received: (qmail 16031 invoked by uid 22791); 7 Nov 2008 12:34:58 -0000 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Nov 2008 12:34:21 +0000 Received: from sunsite.mff.cuni.cz (localhost.localdomain [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id mA7Cde1i027946; Fri, 7 Nov 2008 13:39:40 +0100 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.13.8/8.13.8/Submit) id mA7CdeR8027942; Fri, 7 Nov 2008 13:39:40 +0100 Date: Fri, 07 Nov 2008 12:34:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Remove unnecessary prototypes for __builtin functions Message-ID: <20081107123939.GK32107@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00001.txt.bz2 Hi! This has been apparently workaround for some GCC bug, but I've verified that it makes no difference at all on .plt slots with GCC 4.1, 4.3 and 4.4. In 4.4, we are considering disallowing redefinition of __builtin_* functions, so glibc wouldn't compile at all because of this. 2008-11-07 Jakub Jelinek * include/stdio.h (__builtin_fwrite, __builtin_fwrite_unlocked): Remove. --- libc/include/stdio.h.jj 2008-03-14 22:52:53.000000000 +0100 +++ libc/include/stdio.h 2008-11-07 11:54:33.000000000 +0100 @@ -160,17 +160,6 @@ libc_hidden_proto (__vfprintf_chk) libc_hidden_proto (__vasprintf_chk) libc_hidden_proto (__vdprintf_chk) libc_hidden_proto (__obstack_vprintf_chk) - -# if !defined NOT_IN_libc && defined SHARED && defined DO_VERSIONING \ - && !defined NO_HIDDEN -/* Special gcc builtins. */ -extern size_t __builtin_fwrite (const void *, size_t, size_t, void *) - __asm ("__GI_fwrite"); -extern size_t __builtin_fwrite_unlocked (const void *, size_t, size_t, void *) - __asm ("__GI_fwrite_unlocked"); - -# endif - # endif #endif Jakub