From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3659 invoked by alias); 16 Feb 2009 21:04:04 -0000 Received: (qmail 3643 invoked by uid 22791); 16 Feb 2009 21:04:04 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Feb 2009 21:03:57 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n1GL3rLU015648 for ; Mon, 16 Feb 2009 16:03:53 -0500 Received: from gateway.sf.frob.com (vpn-13-122.rdu.redhat.com [10.11.13.122]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1GL3pBO027368; Mon, 16 Feb 2009 16:03:51 -0500 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id CBFF5357B; Mon, 16 Feb 2009 13:03:51 -0800 (PST) Received: by magilla.sf.frob.com (Postfix, from userid 5281) id 9565EFC3E4; Mon, 16 Feb 2009 13:03:51 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Jakub Jelinek Cc: Ulrich Drepper , Glibc hackers Subject: Re: [PATCH] Uglify function parameter names in installed headers In-Reply-To: Jakub Jelinek's message of Monday, 16 February 2009 16:00:41 +0100 <20090216150041.GE16681@sunsite.ms.mff.cuni.cz> References: <20090216150041.GE16681@sunsite.ms.mff.cuni.cz> Message-Id: <20090216210351.9565EFC3E4@magilla.sf.frob.com> Date: Mon, 16 Feb 2009 21:04:00 -0000 Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00002.txt.bz2 Technically (pedantically) I think it's not necessary to be macro-namespace-clean in headers that aren't C99 headers. IIRC, POSIX says that #include's must come first after feature test macros. That said, I think this is fine to commit.