From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9530-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 17030 invoked by alias); 31 Jul 2009 12:22:01 -0000
Received: (qmail 17011 invoked by uid 22791); 31 Jul 2009 12:22:01 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0
	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Jul 2009 12:21:51 +0000
Received: from sunsite.mff.cuni.cz (localhost [127.0.0.1])
	by sunsite.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id n6VCLWMY023610;
	Fri, 31 Jul 2009 14:21:32 +0200
Received: (from jakub@localhost)
	by sunsite.mff.cuni.cz (8.14.3/8.14.3/Submit) id n6VCLVBW023608;
	Fri, 31 Jul 2009 14:21:31 +0200
Date: Fri, 31 Jul 2009 12:22:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix obstack* on i?86
Message-ID: <20090731122131.GO3101@sunsite.ms.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.19 (2009-01-05)
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00003.txt.bz2

Hi!

obstack calls several callbacks, so on i?86 it'd better be compiled
without -mpreferred-stack-boundary=2, otherwise the callbacks are called
with misaligned stack.

2009-07-31  Jakub Jelinek  <jakub@redhat.com>

	* malloc/Makefile (CFLAGS-obstack.c): Add $(uses-callbacks).

--- libc/malloc/Makefile	2009-05-16 19:23:36.000000000 +0200
+++ libc/malloc/Makefile	2009-07-31 09:09:51.760080072 +0200
@@ -104,6 +104,7 @@ $(objpfx)memusagestat: $(memusagestat-mo
 include ../Rules
 
 CFLAGS-mcheck-init.c = $(PIC-ccflag)
+CFLAGS-obstack.c = $(uses-callbacks)
 
 $(objpfx)libmcheck.a: $(objpfx)mcheck-init.o
 	-rm -f $@

	Jakub