From: Roland McGrath <roland@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Tweak assert -DNDEBUG for the new -Wunused-but-set-{variable,parameter} warnings
Date: Thu, 08 Apr 2010 17:54:00 -0000 [thread overview]
Message-ID: <20100408175406.EBA4AABF@magilla.sf.frob.com> (raw)
In-Reply-To: Jakub Jelinek's message of Thursday, 8 April 2010 12:21:41 +0200 <20100408102141.GO3601@sunsite.ms.mff.cuni.cz>
Unfortunately I think this is wrongly incompatible, as Andreas said.
e.g., consider:
#ifndef NDEBUG
static int checker () { ... }
#endif
...
assert (checker () == 0);
...
Or even worse, it could be hairy macros so that under NDEBUG
the expression is actually unparseable.
Thanks,
Roland
prev parent reply other threads:[~2010-04-08 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 10:22 Jakub Jelinek
2010-04-08 10:49 ` Andreas Schwab
2010-04-08 17:54 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408175406.EBA4AABF@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).