From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9286 invoked by alias); 26 Jul 2010 20:01:23 -0000 Received: (qmail 9268 invoked by uid 22791); 26 Jul 2010 20:01:22 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jul 2010 20:01:15 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6QK1DdW026911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Jul 2010 16:01:13 -0400 Received: from patootie.office.frob.com ([10.3.121.2]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6QK1DEA026609; Mon, 26 Jul 2010 16:01:13 -0400 Received: from magilla.sf.frob.com (magilla.office.frob.com [198.49.250.228]) by patootie.office.frob.com (Postfix) with ESMTP id 90B34263; Mon, 26 Jul 2010 13:01:12 -0700 (PDT) Received: by magilla.sf.frob.com (Postfix, from userid 5281) id 3A695400DD; Mon, 26 Jul 2010 13:01:11 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Andreas Schwab Cc: libc-hacker@sourceware.org Subject: Re: [PATCH] Document M_PERTURB In-Reply-To: Andreas Schwab's message of Monday, 26 July 2010 16:37:45 +0200 References: Message-Id: <20100726200111.3A695400DD@magilla.sf.frob.com> Date: Mon, 26 Jul 2010 20:01:00 -0000 Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00006.txt.bz2 I would s/a value/values/ since there is one value for alloc and one value for free, both based on the perturb byte. I think it should also say "... depending on the low-order byte of this value," so nobody can think that passing in more than 8 bits has any effect. With those tweaks, it's fine to commit it. Thanks, Roland