From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26119 invoked by alias); 26 Jul 2010 20:17:02 -0000 Received: (qmail 26103 invoked by uid 22791); 26 Jul 2010 20:17:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jul 2010 20:16:57 +0000 Received: from sunsite.mff.cuni.cz (localhost [127.0.0.1]) by sunsite.mff.cuni.cz (8.14.4/8.14.3) with ESMTP id o6QKGcFs002251; Mon, 26 Jul 2010 22:16:38 +0200 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.14.4/8.14.4/Submit) id o6QKGcgu002250; Mon, 26 Jul 2010 22:16:38 +0200 Date: Mon, 26 Jul 2010 20:17:00 -0000 From: Jakub Jelinek To: Roland McGrath Cc: Andreas Schwab , libc-hacker@sourceware.org Subject: Re: [PATCH] Document M_PERTURB Message-ID: <20100726201637.GH4815@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20100726200111.3A695400DD@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100726200111.3A695400DD@magilla.sf.frob.com> User-Agent: Mutt/1.5.19 (2009-01-05) Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00007.txt.bz2 On Mon, Jul 26, 2010 at 01:01:11PM -0700, Roland McGrath wrote: > I would s/a value/values/ since there is one value for alloc and one value > for free, both based on the perturb byte. I think it should also say > "... depending on the low-order byte of this value," so nobody can think > that passing in more than 8 bits has any effect. It actually has. MALLOC_PERTURB_=0 doesn't do anything, while MALLOC_PERTURB_=256 does. Jakub