From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6502 invoked by alias); 1 Oct 2010 19:49:29 -0000 Received: (qmail 6483 invoked by uid 22791); 1 Oct 2010 19:49:29 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Oct 2010 19:49:22 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 549018738D; Fri, 1 Oct 2010 21:49:20 +0200 (CEST) From: Andreas Jaeger To: Richard Henderson Subject: Re: Patch to handle cgroup and btrfs filesystems Date: Fri, 01 Oct 2010 19:49:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.34.7-0.3-desktop; KDE/4.5.1; x86_64; ; ) Cc: libc-hacker@sourceware.org References: <201010010632.57347.aj@suse.de> <4CA5FDA4.2060705@twiddle.net> In-Reply-To: <4CA5FDA4.2060705@twiddle.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201010012149.16162.aj@suse.de> Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00003.txt.bz2 On Friday 01 October 2010 17:26:28 Richard Henderson wrote: > On 09/30/2010 09:32 PM, Andreas Jaeger wrote: > > /* Constant that identifies the `bfs' filesystem. */ > > #define BFS_MAGIC 0x1BADFACE > >=20 > > +/* Constant that identifies the `btrfs' filesystem. */ > > +#define BTRFS_SUPER_MAGIC 0x1BADFACE > > + > > +/* Constant that identifies the `cgroup' filesystem. */ > > +#define CGROUP_SUPER_MAGIC 0x1BADFACE >=20 > 3 identical magic's can't be put into the same switch > statements. How did this compile for you? I tested the wrong tree, not sure how emacs tricked me, I copied the values= ;-( thanks for noticing, here's the fix. This time tested with the right tree, Andreas 2010-10-01 Andreas Jaeger * sysdeps/unix/sysv/linux/linux_fsinfo.h (BTRFS_SUPER_MAGIC): Fix value. (CGROUP_SUPER_MAGIC): Likewise. diff --git a/sysdeps/unix/sysv/linux/linux_fsinfo.h b/sysdeps/unix/sysv/lin= ux/linux_fsinfo.h index 8efbdea..b671d2c 100644 --- a/sysdeps/unix/sysv/linux/linux_fsinfo.h +++ b/sysdeps/unix/sysv/linux/linux_fsinfo.h @@ -38,10 +38,10 @@ #define BFS_MAGIC 0x1BADFACE =20 /* Constant that identifies the `btrfs' filesystem. */ -#define BTRFS_SUPER_MAGIC 0x1BADFACE +#define BTRFS_SUPER_MAGIC 0x9123683E =20 /* Constant that identifies the `cgroup' filesystem. */ -#define CGROUP_SUPER_MAGIC 0x1BADFACE +#define CGROUP_SUPER_MAGIC 0x27e0eb =20 /* Constant that identifies the `coda' filesystem. */ #define CODA_SUPER_MAGIC 0x73757245 --=20 Andreas Jaeger, Program Manager openSUSE, aj@{novell.com,opensuse.org} Twitter: jaegerandi | Identica: jaegerandi SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126