From: Roland McGrath <roland@hack.frob.com>
To: Ulrich Drepper <drepper@gmail.com>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: nscd/netlink changes
Date: Mon, 31 Oct 2011 23:47:00 -0000 [thread overview]
Message-ID: <20111031234702.401FD2C0B1@topped-with-meat.com> (raw)
You use the header <netlink/netlink.h> but this belongs to the libnl
package, which AFAICT we are not actually using. It seems better to do:
diff --git a/nscd/connections.c b/nscd/connections.c
index 1b8a9bd..c741996 100644
--- a/nscd/connections.c
+++ b/nscd/connections.c
@@ -34,7 +34,8 @@
#include <unistd.h>
#include <arpa/inet.h>
#ifdef HAVE_NETLINK
-# include <netlink/netlink.h>
+# include <linux/netlink.h>
+# include <linux/rtnetlink.h>
#endif
#ifdef HAVE_EPOLL
# include <sys/epoll.h>
Next, I suspect you had some nscd/Makefile changes that you didn't commit.
The check_pf.c changes seem to suggest that you want to compile that file
separately into nscd rather than using the library version. But nothing
does that. This results in nscd not linking because __bump_nl_timestamp
is not an exported function in the library version of the code.
Thanks,
Roland
next reply other threads:[~2011-10-31 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 23:47 Roland McGrath [this message]
2011-11-01 1:23 ` Ulrich Drepper
2011-11-01 16:44 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031234702.401FD2C0B1@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=drepper@gmail.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).