From: Scott Bambrough <scottb@netwinder.org>
To: libc-hacker mailing list <libc-hacker@sourceware.cygnus.com>
Subject: Patch to allow ARM dynamic linker to fix up PC24 relocs...
Date: Tue, 21 Dec 1999 08:19:00 -0000 [thread overview]
Message-ID: <385FA73A.25126E04@netwinder.org> (raw)
The attached patch adds a cache flush just after the readonly protection
is restored to .text. I've done this in generic code, because the cache
flush is an extremely expensive operation on the ARM. We don't want to
do this after every fixup, and only if we do fixups. The patch as
written should only affect the ARM (or anyone else who defines
CLEAR_CACHE). For all other targets it will disappear after
pre-processing. This patch has the fix for the problem Phil Blundell
pointed out. I've tested it and it seems to work.
1999-12-21 Scott Bambrough <scottb@netwinder.org>
* sysdeps/arm/dl-machine.h (CLEAR_CACHE): New macro to force a
cache flush.
* elf/dl-reloc.c (_dl_relocate_object): Add call to flush cache
after .text segment fixups.
Scott
--
Scott Bambrough - Software Engineer
REBEL.COM http://www.rebel.com
NetWinder http://www.netwinder.org
diff -upr glibc-2.1.2.orig/elf/dl-reloc.c glibc-2.1.2/elf/dl-reloc.c
--- glibc-2.1.2.orig/elf/dl-reloc.c Sat Feb 20 09:45:53 1999
+++ glibc-2.1.2/elf/dl-reloc.c Fri Dec 10 10:36:33 1999
@@ -126,6 +126,10 @@ _dl_relocate_object (struct link_map *l,
if (__mprotect (mapstart, mapend - mapstart, prot) < 0)
_dl_signal_error (errno, l->l_name,
"can't restore segment prot after reloc");
+
+#ifdef CLEAR_CACHE
+ CLEAR_CACHE (mapstart, mapend);
+#endif
}
}
}
diff -upr glibc-2.1.2.orig/sysdeps/arm/dl-machine.h glibc-2.1.2/sysdeps/arm/dl-machine.h
--- glibc-2.1.2.orig/sysdeps/arm/dl-machine.h Tue Aug 10 01:13:22 1999
+++ glibc-2.1.2/sysdeps/arm/dl-machine.h Fri Dec 10 10:36:57 1999
@@ -35,6 +35,14 @@
VALID_ELF_ABIVERSION(hdr[EI_ABIVERSION]) \
)
+#define CLEAR_CACHE(BEG,END) \
+{ \
+ register unsigned long _beg __asm ("a1") = (unsigned long)(BEG); \
+ register unsigned long _end __asm ("a2") = (unsigned long)(END); \
+ register unsigned long _flg __asm ("a3") = 0; \
+ __asm __volatile ("swi 0x9f0002"); \
+}
+
/* Return nonzero iff E_MACHINE is compatible with the running host. */
static inline int __attribute__ ((unused))
elf_machine_matches_host (Elf32_Half e_machine)
next reply other threads:[~1999-12-21 8:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-21 8:19 Scott Bambrough [this message]
1999-12-21 8:29 ` Ulrich Drepper
1999-12-21 8:37 ` Scott Bambrough
-- strict thread matches above, loose matches on Subject: below --
1999-12-07 11:50 Scott Bambrough
1999-12-07 12:12 ` Philip Blundell
1999-12-07 18:37 ` Richard Henderson
[not found] ` <E11veej-0007M5-00@>
1999-12-17 8:53 ` Scott Bambrough
[not found] ` <E11z0kF-0000TS-00@fountain.labs.futuretv.com>
1999-12-17 9:40 ` Scott Bambrough
1999-12-07 23:38 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385FA73A.25126E04@netwinder.org \
--to=scottb@netwinder.org \
--cc=libc-hacker@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).