public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix Alpha TLS
@ 2003-02-13 21:26 Jakub Jelinek
  2003-02-14  6:02 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2003-02-13 21:26 UTC (permalink / raw)
  To: Ulrich Drepper, Richard Henderson; +Cc: Glibc hackers

Hi!

I've noticed that I was accidentally building alpha --without-tls, not
--with-tls. Fixing that revealed a bug in dl-machine.h.
With this --with-tls --without-__thread passes make check on alpha.

2003-02-13  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/alpha/dl-machine.h (elf_machine_rela): Add instead of
	subtracting map->l_tls_offset.

--- libc/sysdeps/alpha/dl-machine.h.jj	2003-01-30 05:01:48.000000000 -0500
+++ libc/sysdeps/alpha/dl-machine.h	2003-02-13 16:23:45.000000000 -0500
@@ -627,12 +627,12 @@ elf_machine_rela (struct link_map *map,
       else if (r_type == R_ALPHA_TPREL64)
 	{
 #ifdef RTLD_BOOTSTRAP
-	  *reloc_addr = sym_raw_value - map->l_tls_offset;
+	  *reloc_addr = sym_raw_value + map->l_tls_offset;
 #else
 	  if (sym_map)
 	    {
 	      CHECK_STATIC_TLS (map, sym_map);
-	      *reloc_addr = sym_raw_value - sym_map->l_tls_offset;
+	      *reloc_addr = sym_raw_value + sym_map->l_tls_offset;
 	    }
 #endif
 	}


	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix Alpha TLS
  2003-02-13 21:26 [PATCH] Fix Alpha TLS Jakub Jelinek
@ 2003-02-14  6:02 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2003-02-14  6:02 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Richard Henderson, Glibc hackers

Jakub Jelinek wrote:

> I've noticed that I was accidentally building alpha --without-tls, not
> --with-tls. Fixing that revealed a bug in dl-machine.h.
> With this --with-tls --without-__thread passes make check on alpha.

Thanks, I've applied the patch.

-- 
--------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-14  6:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-13 21:26 [PATCH] Fix Alpha TLS Jakub Jelinek
2003-02-14  6:02 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).