From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12763 invoked by alias); 8 Mar 2004 18:39:36 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 12707 invoked from network); 8 Mar 2004 18:39:33 -0000 Received: from unknown (HELO myware.akkadia.org) (24.221.190.179) by sources.redhat.com with SMTP; 8 Mar 2004 18:39:33 -0000 Received: from redhat.com (drepper@myware.akkadia.org [192.168.7.70]) (authenticated bits=0) by myware.akkadia.org (8.12.11/8.12.10) with ESMTP id i28IdDnQ003730; Mon, 8 Mar 2004 10:39:14 -0800 Message-ID: <404CBDD1.10306@redhat.com> Date: Mon, 08 Mar 2004 18:39:00 -0000 From: Ulrich Drepper Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040307 MIME-Version: 1.0 To: sjmunroe@vnet.ibm.com CC: libc-hacker@sources.redhat.com Subject: Re: [PATCH] PPC64 dl-machine.c change to use GLRO References: <404CAB15.2090806@us.ibm.com> In-Reply-To: <404CAB15.2090806@us.ibm.com> X-Enigmail-Version: 0.83.3.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-03/txt/msg00025.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Steve Munroe wrote: > > - INTUSE (_dl_signal_error) (0, map->l_name, NULL, buffer); > + GLRO(dl_signal_error) (0, map->l_name, NULL, buffer); > } Not correct. You need to use GLRO for that function only outside ld.so. I've checked in a patch. Oh, and you again haven't updated the copyright year. In case you use emacs, use upd-copyr.el (and whitespace.el, I've removed a lot of excess whitespaces in the ppc files in the last days). If you use something else which has macro capabilities try to get something like upd-copyr.el implemented. It checks for accurate copyright years before saving. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFATL3R2ijCOnn/RHQRAs12AJ0QiLVcTHvEYP7zdSP7fN2YgF8jgACggpRe nVOLHCxxFwk2WzcsNkp3sbU= =Uufu -----END PGP SIGNATURE-----