From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16430 invoked by alias); 26 Aug 2004 09:12:33 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 16363 invoked from network); 26 Aug 2004 09:12:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 26 Aug 2004 09:12:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7Q9CQS0009251 for ; Thu, 26 Aug 2004 05:12:31 -0400 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7Q9CQ316065; Thu, 26 Aug 2004 05:12:26 -0400 Received: from [10.0.1.84] (drepper.cipe.redhat.com [10.0.1.84]) by lacrosse.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7Q9CMr29505; Thu, 26 Aug 2004 05:12:23 -0400 Message-ID: <412DA970.2060604@redhat.com> Date: Thu, 26 Aug 2004 09:12:00 -0000 From: Ulrich Drepper Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040825 MIME-Version: 1.0 To: Kaz Kojima CC: libc-hacker@sources.redhat.com Subject: Re: [PATCH] SH: Fixup pread/pwrite References: <20040825.165724.32717645.kkojima@rr.iij4u.or.jp> In-Reply-To: <20040825.165724.32717645.kkojima@rr.iij4u.or.jp> X-Enigmail-Version: 0.85.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-08/txt/msg00072.txt.bz2 Kaz Kojima wrote: > The pread/write* stuff of sh-linux just includes the mips one and now > the mips implementation uses more mips specific things like sgidefs.h > which doesn't exist on SH. The appended patch just copies them and > removes the mips specific lines from them. Yeah, but it's a copy. I would rather like to see you using the other files. Yet another copy means more maintenance problems. You can define a macro in the SH files which prevents the MIPS header from being included. Or maybe this is even one of the rare situations where it is OK to test for __mips__ or whatever the symbol gcc defines is since it is indeed only for mips you want these headers. -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖