public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix addseverity
Date: Tue, 25 Jan 2005 22:19:00 -0000	[thread overview]
Message-ID: <41F6C4E5.8090302@redhat.com> (raw)
In-Reply-To: <20050125221300.GM4777@sunsite.mff.cuni.cz>

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Jakub Jelinek wrote:
> if the string passed to addseverity is freed by the caller,
> we still reference freed up memory, or if the string passed to addseverity
> is overwritten, we use whatever it was overwritten to.

I've never seen anything to the contrary that this is acceptable.  The 
function is not part of any spec and when I wrote this code this seemed 
to be what other implementations did.  What program has problems with 
the current code?

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

  reply	other threads:[~2005-01-25 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-25 22:13 Jakub Jelinek
2005-01-25 22:19 ` Ulrich Drepper [this message]
2005-01-25 22:58   ` [PATCH] Fix addseverity (take 2) Jakub Jelinek
2005-01-26  0:01     ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F6C4E5.8090302@redhat.com \
    --to=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).