public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix dl-load.c typo
@ 2005-02-08 18:03 Jakub Jelinek
  2005-02-08 21:40 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2005-02-08 18:03 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Glibc hackers

Hi!

Following typo seems to be the cause of:
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls9.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls4.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls5.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls7.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls6.out] Error 1
make[2]: *** [/usr/src/libc/objl/elf/tst-tls8.out] Error 1
in linuxthreads build.
The result is that _dl_tls_setup () is not called although it should.

2005-02-08  Jakub Jelinek  <jakub@redhat.com>

	* elf/dl-load.c (_dl_map_object_from_fd): Fix a typo.

--- libc/elf/dl-load.c.jj	2005-02-08 17:24:04.000000000 +0100
+++ libc/elf/dl-load.c	2005-02-08 18:58:05.584415097 +0100
@@ -1084,7 +1084,7 @@ _dl_map_object_from_fd (const char *name
 	    }
 
 # ifdef SHARED
-	  if (l->l_prev == NULL || (mode && __RTLD_AUDIT) != 0)
+	  if (l->l_prev == NULL || (mode & __RTLD_AUDIT) != 0)
 	    /* We are loading the executable itself when the dynamic linker
 	       was executed directly.  The setup will happen later.  */
 	    break;


	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix dl-load.c typo
  2005-02-08 18:03 [PATCH] Fix dl-load.c typo Jakub Jelinek
@ 2005-02-08 21:40 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2005-02-08 21:40 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Glibc hackers

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

Applied.

--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-08 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-08 18:03 [PATCH] Fix dl-load.c typo Jakub Jelinek
2005-02-08 21:40 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).