From: Steven Munroe <munroesj@us.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: things to do for arch maintainers
Date: Tue, 20 Dec 2005 23:34:00 -0000 [thread overview]
Message-ID: <43A8A238.4060609@us.ibm.com> (raw)
In-Reply-To: <20051220211255.GR4625@sunsite.mff.cuni.cz>
Jakub Jelinek wrote:
>On Tue, Dec 20, 2005 at 04:05:40PM -0600, Steven Munroe wrote:
>
>
>>Jakub got to the powerpc change before I could finish testing my
>>version. No problem with Jukub's quickness, but I notice that his
>>version does not fill in the
>>
>>"#if defined NOT_IN_libc && defined IS_IN_rtld"
>>
>>
>>case. While the X86_64 example does.
>>
>>
>
>Uli did that part already earlier for
>sysdeps/powerpc/powerpc32/setjmp-common.S:
>
>#if defined NOT_IN_libc && defined IS_IN_rtld
> li r3,0
> blr
>#else
> b BP_SYM (__sigjmp_save@local)
>#endif
>
>
>
I was refering to defining the PTR_MANGLE/PTR_DEMANGLE macros for the
IS_IN_RTLD case. X86_64 defines:
#if defined NOT_IN_libc && defined IS_IN_rtld
/* We cannot use the thread descriptor because in ld.so we use setjmp
earlier than the descriptor is initialized. */
# ifdef __ASSEMBLER__
# define PTR_MANGLE(reg) xorq __pointer_chk_guard_local(%rip), reg
# define PTR_DEMANGLE(reg) PTR_MANGLE (reg)
# else
# define PTR_MANGLE(reg) asm ("xorq
__pointer_chk_guard_local(%%rip), %0"\
: "=r" (reg) : "0" (reg))
# define PTR_DEMANGLE(reg) PTR_MANGLE (reg)
# endif
...
While powerpc and most other arch's leave the macros undefined for the
IS_IN_RTLD case.
This may be appropriate because powerpc does not have a pc relative
reference to access __pointer_chk_guard_local and access via the
.got/.toc will fail if access is attemped before the got/toc are
relocated. But I wanted to verify this.
It is not clear what this change is really for, so it is difficult to
determine what is intended or required.
next prev parent reply other threads:[~2005-12-20 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 19:11 Ulrich Drepper
2005-12-19 22:12 ` Jakub Jelinek
2005-12-20 6:55 ` Ulrich Drepper
2005-12-20 9:09 ` Kaz Kojima
2005-12-20 15:32 ` Ulrich Drepper
2005-12-21 0:57 ` Kaz Kojima
2005-12-20 21:08 ` Steven Munroe
2005-12-20 21:13 ` Jakub Jelinek
2005-12-20 23:34 ` Steven Munroe [this message]
2005-12-20 23:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A8A238.4060609@us.ibm.com \
--to=munroesj@us.ibm.com \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).