From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9281 invoked by alias); 1 Mar 2006 15:49:06 -0000 Received: (qmail 9263 invoked by uid 22791); 1 Mar 2006 15:49:06 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Mar 2006 15:49:04 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k21Fn2CR028062 for ; Wed, 1 Mar 2006 10:49:02 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k21Fmv119116; Wed, 1 Mar 2006 10:48:57 -0500 Received: from [192.168.7.71] (vpn83-172.boston.redhat.com [172.16.83.172]) by lacrosse.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k21Fmjt22574; Wed, 1 Mar 2006 10:48:48 -0500 Message-ID: <4405C2B7.4070005@redhat.com> Date: Wed, 01 Mar 2006 15:49:00 -0000 From: Ulrich Drepper User-Agent: Thunderbird 1.5 (X11/20060128) MIME-Version: 1.0 To: "David S. Miller" CC: libc-hacker@sources.redhat.com Subject: Re: [PATCH]: Sparc SUN4V Niagara optimized memset/memcpy References: <20060301.005521.123780069.davem@davemloft.net> In-Reply-To: <20060301.005521.123780069.davem@davemloft.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig45C2E886E9880C0873801826" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00003.txt.bz2 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig45C2E886E9880C0873801826 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 594 David S. Miller wrote: > +ENTRY(memset) > + /* %o0=3Dbuf, %o1=3Dpat, %o2=3Dlen */ > + and %o1, 0xff, %o3 > + mov %o2, %o1 > + sllx %o3, 8, %g1 > + or %g1, %o3, %o2 > + sllx %o2, 16, %g1 > + or %g1, %o2, %o2 > + sllx %o2, 32, %g1 > + ba,pt %XCC, 1f > + or %g1, %o2, %o2 > + > +ENTRY(__bzero) This is confusing data. No two functions should overlap. I suggest to make bzero a little function calling memset similar to what you did with bcopy. Second, add cfi. --=20 =E2=9E=A7 Ulrich Drepper =E2=9E=A7 Red Hat, Inc. =E2=9E=A7 444 Castro St = =E2=9E=A7 Mountain View, CA =E2=9D=96 --------------enig45C2E886E9880C0873801826 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 251 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFEBcK82ijCOnn/RHQRAvt1AKC50A5N8LJFHIHzX3YmArZPKz740ACfdgJC gLLXubfQtCWLSngIe1Lnmcg= =O2XE -----END PGP SIGNATURE----- --------------enig45C2E886E9880C0873801826--