From: Steven Munroe <munroesj@us.ibm.com>
To: GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix build break from ifaddrs.h
Date: Wed, 19 Apr 2006 21:32:00 -0000 [thread overview]
Message-ID: <4446AF36.5090007@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Todays CVS breaks in sunrpc/pmap_cint.c because uint32_t is not defined.
Adding the include <stdint.h> fixed this. But there are additional
failure in make check. posix/tst-rfc3484.c and tst-rfc3484-2.c fail
because they redefine __check_pf and the prototype does not match. I
updated tst-rfc3484.c and tst-rfc3484-2.c to match ifaddrs.h.
That seems to get tst-rfc3484.c and tst-rfc3484-2.c working but I am
still see failures in posix/tst-getaddrinfo and posix/tst-getaddrinfo-2.
I have not debugges these yet.
[-- Attachment #2: ppc-ifaddrs-20060419.txt --]
[-- Type: text/plain, Size: 1812 bytes --]
2006-04-19 Steven Munroe <sjmunroe@us.ibm.com>
* include/ifaddrs.h: Include <stdint.h>
* posix/tst-rfc3484-2.c (__check_pf): Update prototype to match
ifaddrs.h.
* posix/tst-rfc3484.c (__check_pf): Likewise.
diff -urN libc24-cvstip-20060419/include/ifaddrs.h libc24/include/ifaddrs.h
--- libc24-cvstip-20060419/include/ifaddrs.h 2006-04-16 16:26:00.000000000 -0500
+++ libc24/include/ifaddrs.h 2006-04-19 15:35:40.000000000 -0500
@@ -1,6 +1,7 @@
#ifndef _IFADDRS_H
#include <inet/ifaddrs.h>
#include <stdbool.h>
+#include <stdint.h>
libc_hidden_proto (getifaddrs)
libc_hidden_proto (freeifaddrs)
diff -urN libc24-cvstip-20060419/posix/tst-rfc3484-2.c libc24/posix/tst-rfc3484-2.c
--- libc24-cvstip-20060419/posix/tst-rfc3484-2.c 2006-04-15 16:41:54.000000000 -0500
+++ libc24/posix/tst-rfc3484-2.c 2006-04-19 15:11:35.000000000 -0500
@@ -1,5 +1,6 @@
#include <stdbool.h>
#include <stdio.h>
+#include <ifaddrs.h>
/* Internal definitions used in the libc code. */
#define __getservbyname_r getservbyname_r
@@ -11,7 +12,8 @@
void
attribute_hidden
-__check_pf (bool *p1, bool *p2)
+__check_pf (bool *p1, bool *p2,
+ struct in6addrinfo **in6ai, size_t *in6ailen)
{
*p1 = *p2 = true;
}
diff -urN libc24-cvstip-20060419/posix/tst-rfc3484.c libc24/posix/tst-rfc3484.c
--- libc24-cvstip-20060419/posix/tst-rfc3484.c 2005-09-26 16:12:49.000000000 -0500
+++ libc24/posix/tst-rfc3484.c 2006-04-19 15:06:41.000000000 -0500
@@ -1,5 +1,6 @@
#include <stdbool.h>
#include <stdio.h>
+#include <ifaddrs.h>
/* Internal definitions used in the libc code. */
#define __getservbyname_r getservbyname_r
@@ -11,7 +12,8 @@
void
attribute_hidden
-__check_pf (bool *p1, bool *p2)
+__check_pf (bool *p1, bool *p2,
+ struct in6addrinfo **in6ai, size_t *in6ailen)
{
*p1 = *p2 = true;
}
reply other threads:[~2006-04-19 21:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4446AF36.5090007@us.ibm.com \
--to=munroesj@us.ibm.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).