From: Steven Munroe <munroesj@us.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix ppc32 lrint (BZ #3155)
Date: Thu, 07 Sep 2006 16:18:00 -0000 [thread overview]
Message-ID: <45004788.2020607@us.ibm.com> (raw)
In-Reply-To: <20060907133822.GX4556@sunsite.mff.cuni.cz>
Jakub Jelinek wrote:
>Hi!
>
>PPC32 ABI forbids stack accesses below r1 (unlike PPC64 ABI).
>The following patch fixes lrint which was violating this (detected by
>valgrind).
>There are 4 other ppc32 files that violate this:
>libc/sysdeps/powerpc/powerpc32/fpu/fprrest.S
>libc/sysdeps/powerpc/powerpc32/fpu/fprsave.S
>libc/sysdeps/powerpc/powerpc32/gprrest0.S
>libc/sysdeps/powerpc/powerpc32/gprsave0.S
>The stubs from those files aren't exported from libc.so.6 nor actually
>used for anything there, so I wonder if we can't nuke them altogether,
>or if they should move to libc_nonshared.a after making all the functions
>.hidden there. GCC provides (some of) the PPC32 ABI mandates stubs
>in crtsavres.o (and there it accesses memory below r11, not r1),
>so I'm not 100% if we need these at all.
>
I am not sure where these came from or their history. As you say they
don't match the Linux ABI but we can get away with this because of the
way the kernel's signal.c builds signal frames. Not something we should
depend on. Easiest to just remove them from sysdeps/powerpc/powerpc32.
Looks like they do match the AIX xcoff ABI. So perhaps they should be
moved to sysdeps/unix/sysv/aix. I don't know who if any one is
maintaining the AIX code in libc. I'll check around.
prev parent reply other threads:[~2006-09-07 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 13:38 Jakub Jelinek
2006-09-07 13:47 ` Ulrich Drepper
2006-09-07 16:18 ` Steven Munroe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45004788.2020607@us.ibm.com \
--to=munroesj@us.ibm.com \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).