From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9229-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 26781 invoked by alias); 2 May 2007 14:06:58 -0000
Received: (qmail 26718 invoked by uid 22791); 2 May 2007 14:06:57 -0000
X-Spam-Check-By: sourceware.org
Received: from e36.co.us.ibm.com (HELO e36.co.us.ibm.com) (32.97.110.154)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 May 2007 14:06:55 +0000
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106])
	by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l42E6o17021675
	for <libc-hacker@sources.redhat.com>; Wed, 2 May 2007 10:06:50 -0400
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l42E6nGg113642
	for <libc-hacker@sources.redhat.com>; Wed, 2 May 2007 08:06:49 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l42E6mgx018072
	for <libc-hacker@sources.redhat.com>; Wed, 2 May 2007 08:06:49 -0600
Received: from [9.10.86.122] (spokane1.rchland.ibm.com [9.10.86.122])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l42E6mRI017964;
	Wed, 2 May 2007 08:06:48 -0600
Message-ID: <46389F1F.9080302@us.ibm.com>
Date: Wed, 02 May 2007 14:06:00 -0000
From: Steven Munroe <munroesj@us.ibm.com>
User-Agent: Mozilla/5.0 (X11; U; Linux ppc64; en-US; rv:1.8.0.9) Gecko/20060906 SUSE/1.8_seamonkey_1.0.7-1.1 SeaMonkey/1.0.7
MIME-Version: 1.0
To: Ulrich Drepper <drepper@redhat.com>
CC: GNU libc hacker <libc-hacker@sources.redhat.com>,
        Jakub Jelinek <jakub@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] PPC fenv fixes 4th update
References: <4637BE8E.9020107@us.ibm.com> <46384A0D.4070405@redhat.com>
In-Reply-To: <46384A0D.4070405@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2007-05/txt/msg00003.txt.bz2

Ulrich Drepper wrote:
> Steven Munroe wrote:
>   
>> +/* This is presently a stub, until it's decided how the kernels should
>> +   support this.  */
>> +
>> +const fenv_t *
>> +__fe_mask_env(void)
>> +{
>> +  __set_errno (ENOSYS);
>> +  return FE_DFL_ENV;
>> +}
>>     
>
> Why are you sending a patch if it's incomplete?  Fix the kernel and then
> send a patch.  Who knows, maybe a completely different solution is needed.
>
>   
The only problem is the comment which should say:

/* This is a generic stub. An OS specific override is required to clear
   the FE0/FE1 bits in the MSR.  MSR update is privileged, so this will
   normally involve a syscall.  */

The real implementations for linux are in
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fe_mask.c

hhhmm should not this be?:
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fpu/fe_mask.c

History bites. Dr. Bergner just copied the existing fe_nomask.c stubs
and overrides. I'll fix it and resubmit.