From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14671 invoked by alias); 23 Jul 2007 22:09:21 -0000 Received: (qmail 14655 invoked by uid 22791); 23 Jul 2007 22:09:21 -0000 X-Spam-Check-By: sourceware.org Received: from e1.ny.us.ibm.com (HELO e1.ny.us.ibm.com) (32.97.182.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Jul 2007 22:09:13 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6NM96Zi025089 for ; Mon, 23 Jul 2007 18:09:06 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6NM96oQ507792 for ; Mon, 23 Jul 2007 18:09:06 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6NM96Uv010494 for ; Mon, 23 Jul 2007 18:09:06 -0400 Received: from [127.0.0.1] (wecm-9-67-174-153.wecm.ibm.com [9.67.174.153]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l6NM93fD010428; Mon, 23 Jul 2007 18:09:05 -0400 Message-ID: <46A52700.50905@us.ibm.com> Date: Mon, 23 Jul 2007 22:09:00 -0000 From: Steven Munroe User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 MIME-Version: 1.0 To: Jakub Jelinek CC: Ulrich Drepper , GNU libc hacker Subject: Re: [PATCH] clean up PPC for private futex changes. References: <4697E92C.1010403@us.ibm.com> <46A4D2F3.7060005@redhat.com> <20070723204237.GE4603@sunsite.mff.cuni.cz> In-Reply-To: <20070723204237.GE4603@sunsite.mff.cuni.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00041.txt.bz2 Jakub Jelinek wrote: >On Mon, Jul 23, 2007 at 09:10:27AM -0700, Ulrich Drepper wrote: > > >>-----BEGIN PGP SIGNED MESSAGE----- >>Hash: SHA1 >> >>Applied. >> >> > >Unfortunately that patch contains several important bugs: >1) lll_futex_wait etc. had only correct definition when > __ASSUME_PRIVATE_FUTEX, when that is not true, it would > call futex syscall with bit 7 set even when libpthread.so > init determined it is not supported > > Ya, I was looking at the x86_64 code which did seem incomplete to me. So I tried to go one step better for PPC. But how can header.private_futex be set in the absence of __ASSUME_PRIVATE_FUTEX? >2) lll_private_futex_wait etc. macros were shared when > not __ASSUME_PRIVATE_FUTEX >3) FUTEX_WAKE_OP had the wake operation argument also ored > with 128 in some cases > > Ya, I was concerned about that, but the examples from i386 and x86_64 where not clear to me... >Here is how it IMHO should look like (built and tested on ppc64-linux, >unfortunately not wiht a 2.6.23ish kernel). > > This looks better. Thanks